Part of story #12447: Modal new document for empty/wiki/link Go to a folder where you don't have permission to create documents (remove write capability). => the [new document] in the header is not displayed. Go to a folder where you have permission to create documents (add write capability). => the [new document] in the header is displayed. Go to an empty folder where you don't have permission to create documents (remove write capability). => the [new document] in the empty state is not displayed. Go to an empty folder where you have permission to create documents (add write capability). => the [new document] in the empty state is displayed. This is a first step, to introduce the current_folder as object in the store, and move actions.js in smaller parts for better understability. A next patch will propose two different empty states: one for writers, one for readers. Implementation note ------------------- Since the display of the empty state depends on both the content of the folder (is it empty?) and the current folder property (has user write capability?), and to limit the number of rest calls (get parents for breadcrumbs, get item for breadcrumbs and title and write capability, get folder content) we need to pass "get item" promise as argument, and wait for its resoution or else «Paf! Ça fait des Chocapics!». Here is a diagram of the flow before this changeset: (router magic) | | ___ / \ Y / \ N +----------------- root? ---------------------------------------------+ | \ / | | \___/ | | | --------------+------------------- ----------------+----------------------------- -------+-----------------------+-- ------+--------------------------------+------ | | | | +----------+--------------+ +------+---------+ +--------------+---------+ +----------+-----------+ | resetAscendantHierarchy | | loadRootFolder | | loadAscendantHierarchy | | loadFolderContent * | +----------+--------------+ +------+---------+ +---------+--------------+ +----------+-----------+ | | | | | ############### # _______ | | # getProject # < - - - -` / \ +--------+---------+ | ############### | N / \ Y | getFolderContent | | | +------ in cache? -----------+ +--------+---------+ | | | | \ / | | | +--------+-------------+ | \_______/ | | | | loadFolderContent * | | | | | | +--------+-------------+ -----+------------ | | | | | --+------------+-- | | | | v | | | | | | | | | | | | ############# +----+---------+ | | -------+-----------------------+-- # getItem # | getParents | | | --------------+------------------- ############# +----+---------+ | | | | | | | | --+------------+-- | | | --------+--------- | | | | | | | ---+-------------------------+--------------------+--- | --------------------------+--------------------------- | | +-------------------+-------------------------------------------------+ | Notes: *: loadFolderContent is called both for root folder and child folder #: getProject and getItem are retrieving the current folder properties Since getFolderContent must be resolved at the same time than the retrieval of current folder properties, we need to start the retrieval of those properties earlier in the stack. This gives the following diagram: (router magic) | | ___ / \ Y / \ N +----------------- root? ---------------------------------------------+ | \ / | | \___/ +------+-----+ | | loadFolder | --------------+------------------- +------+-----+ -------+-----------------------+-- | | | | +----------+--------------+ +------+---------+ _______ | resetAscendantHierarchy | | loadRootFolder | / \ +----------+--------------+ +------+---------+ N / \ Y | | +------ in cache? --------------------+ | ############### | \ / | | # getProject # | \_______/ | | ############### | | | | \\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\ \#\#\#\#\#\#\#\#\#\#\#\#\# | | | create promise with cached folder | | create getItem promise | | \\\\\\\\\\\\\\\\\\\\\\\\\\\\ \\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\ #\#\#\#\#\#\#\#\#\#\#\#\#\ | | create promise with root | | | | \\\\\\\\\\\\\\\\\\\\\\\\\\\\ +-----------+-------------------------+ | | | | +------------+--------------+ -----------------+--------------------------------------- | | getFolderContent(promise) | ----+-----------------------------------------------+---- | +------------+--------------+ | | | | +-----------+--------------------+ +------------+---------------+ -------+-----------------------+-- | loadAscendantHirarchy(promise) | | loadFolderContent(promise) | --------------+------------------- +-----------+--------------------+ +------------+---------------+ | | | | -----+------------ -----+------------ | --+------------+-- --+------------+-- | | | | | | | | | | | ////////////// +---+----------+ ////////////// +---+---------------+ | / promise ! / | getParents | / promise ! / | getFolderContent | | ////////////// +---+----------+ ////////////// +---+---------------+ | | | | | | --+------------+-- --+------------+-- | --------+--------- --------+--------- | | | | ---+-----------------------------------------------+--- | --------------------------+---------------------------- | | +--------------------+--------------------------------------------------------------+ | Change-Id: Id3f06f7c64eb115f16243229a6c071716b31b4c7

+669 −327

Author

Nicolas Terray (nterray) 2018-12-12 17:06

Committer

Nicolas Terray (nterray) 2018-12-13 15:11

Hash ff5041aafb91913ad8eda65e8397755946af221e

Parent 0fef3a8211f7cc642cdce155517515aa3272e9c1

Reference git #tuleap/stable/ff5041aafb91913ad8eda65e8397755946af221e