Public

Project privacy set to public. By default, its content is available to everyone (authenticated or not). Please note that more restrictive permissions might exist on some items.

stable

Clone or download

Read-only

Refactoring: Use slots instead of CardMixin

Download Browse

Composition over inheritance! * decrease duplication * easier to test (no need to duplicate tests among children of the mixin) No functional changes. Part of story #13629: Update the title semantic of a card Change-Id: I6c282c93ab9ebf229d19f97ce790811ca0d86a6b

+134 −176
Nicolas Terray (nterray) 2019-11-21 15:03
Nicolas Terray (nterray) 2019-11-22 09:59
0010627a6dc778678b9074009e69392c79420432
eb318a0d2165aeb89d589097d7dda0e64eae7377
git #tuleap/stable/0010627a6dc778678b9074009e69392c79420432

Modified Files

Side by side diff
Inline diff
Name
R plugins/taskboard/scripts/taskboard/src/components/TaskBoard/Body/Swimlane/Card/ParentCard.test.ts Go to diff View file
A plugins/taskboard/scripts/taskboard/src/components/TaskBoard/Body/Swimlane/Card/BaseCard.vue +88 −0 Go to diff View file
M plugins/taskboard/scripts/taskboard/src/components/TaskBoard/Body/Swimlane/Card/ChildCard.test.ts +15 −41 Go to diff View file
M plugins/taskboard/scripts/taskboard/src/components/TaskBoard/Body/Swimlane/Card/ChildCard.vue +13 −18 Go to diff View file
M plugins/taskboard/scripts/taskboard/src/components/TaskBoard/Body/Swimlane/Card/ParentCard.vue +18 −19 Go to diff View file
D plugins/taskboard/scripts/taskboard/src/components/TaskBoard/Body/Swimlane/Card/__snapshots__/ParentCard.test.ts.snap +0 −34 Go to diff View file
D plugins/taskboard/scripts/taskboard/src/components/TaskBoard/Body/Swimlane/Card/card-mixin.ts +0 −64 Go to diff View file