stable
Clone or download
Read-only
DBSetupParameters was introduce to ease the management of the configuration at setup time but I realized it was a bad move related to generalization of the approach. In order to manage local.inc, I will need to re-use the code that sits now in DatabaseConfigurator (getVariableForConfigFile) but this code was managing explicitly the value to serialize and, worst, default values were managed explicitly while now we can define those default values directly on the ConfigKey. Part-of: story #22708 flexibility in the management of Tuleap Configuration Change-Id: I844c5716b968507a54f78aa4635318a2b8d813f1
Modified Files
| Name | ||||
|---|---|---|---|---|
| M | src/common/Config/ConfigKeyLegacyBool.php | +6 | −3 | Go to diff View file |
| M | src/common/Config/ForgeConfig.php | +6 | −1 | Go to diff View file |
| M | src/tuleap-cfg/Command/Docker/Tuleap.php | +6 | −6 | Go to diff View file |
| M | src/tuleap-cfg/Command/SetupMysql/ConnectionManager.php | +16 | −19 | Go to diff View file |
| M | src/tuleap-cfg/Command/SetupMysql/ConnectionManagerInterface.php | +10 | −14 | Go to diff View file |
| M | src/tuleap-cfg/Command/SetupMysql/DBSetupParameters.php | +7 | −91 | Go to diff View file |
| M | src/tuleap-cfg/Command/SetupMysql/DatabaseConfigurator.php | +39 | −43 | Go to diff View file |
| M | src/tuleap-cfg/Command/SetupMysql/MysqlCommandHelper.php | +34 | −14 | Go to diff View file |
| M | src/tuleap-cfg/Command/SetupMysqlInitCommand.php | +51 | −34 | Go to diff View file |
| D | tests/unit/tuleap-cfg/Command/SetupMysql/DBSetupParametersTest.php | +0 | −134 | Go to diff View file |
| M | tests/unit/tuleap-cfg/Command/TestConnectionManager.php | +2 | −1 | Go to diff View file |