stable
Clone or download
Some tests were modifying the global state with mock objects resulting in crashes when @runInSeparateProcess is used. By default, PHPUnit tries to preserve the global state when starting a new process but in PHP 7.4 the mock objects generated by Mockery cannot be serialized because that means serializing ReflectionClass instances which is now forbidden. It is expected from a Tuleap unit test to leave the global state unmodified after its execution. This was supposedly enforced by the PHPUnit configuration but a setting was missing to make it work as expected in PHPUnit 6+. The configuration has been fixed to identified the broken tests and the tests have been fixed. Part of request #13487: Run Tuleap test suites with PHP 7.4 Change-Id: Idffe140a16b2c8e4674c9b5fa82304a6df0e3c57
Modified Files
| Name | ||||
|---|---|---|---|---|
| M | Makefile | +7 | −0 | Go to diff View file |
| M | plugins/agiledashboard/phpunit/AgileDashboard/Semantic/SemanticDoneLoaderTest.php | +5 | −0 | Go to diff View file |
| M | plugins/docman/phpunit/DocmanValidateUploadTest.php | +5 | −0 | Go to diff View file |
| M | plugins/dynamic_credentials/phpunit/User/DynamicUserCreatorTest.php | +1 | −3 | Go to diff View file |
| M | plugins/git/phpunit/Git/AdminGerritControllerTest.php | +5 | −0 | Go to diff View file |
| M | plugins/git/phpunit/HTTP/HTTPAccessControlTest.php | +1 | −3 | Go to diff View file |
| M | plugins/gitlfs/phpunit/LFSJSONHTTPDispatchableTest.php | +1 | −1 | Go to diff View file |
| M | plugins/timetracking/phpunit/ArtifactView/ArtifactViewBuilderTest.php | +7 | −4 | Go to diff View file |
| M | src/www/include/nusoap.php | +2 | −32 | Go to diff View file |
| M | tests/Jenkinsfile-nightly | +13 | −0 | Go to diff View file |
| M | tests/lib/GlobalLanguageMock.php | +3 | −13 | Go to diff View file |
| M | tests/phpunit/common/Backend/BackendSVNTest.php | +23 | −2 | Go to diff View file |
| M | tests/phpunit/common/Project/ProjectCreatorTest.php | +29 | −0 | Go to diff View file |
| M | tests/phpunit/common/Project/ProjectXMLImporterTest.php | +14 | −1 | Go to diff View file |
| M | tests/phpunit/phpunit.xml | +4 | −1 | Go to diff View file |