Public

Project privacy set to public. By default, its content is available to everyone (authenticated or not). Please note that more restrictive permissions might exist on some items.

stable

Clone or download

Read-only

Empty followups are not displayed in Modale V2

Download Browse

This is part of story #19275 restrict who can see comments How to test: - Have some follow-ups - with comments not private - With private comment and changes - with only changes - with only private comments - with private comments and changes on field that user can't see Expected results: - Open modale v2 in planning UI - User sees follow-ups with changes and comment that it can see - There are no empty follow-ups Change-Id: Ib6c897a889a8280402375e7355365fe5003c9342

+676 −13
Benjamin Bouillot (ben.bouillot) 2021-02-26 15:17
Benjamin Bouillot (ben.bouillot) 2021-03-02 11:36
0edf674753924bd6fd60b8d5624b7d3f2b9d1411
4218dac8e617d0ad60a66b336458c8345b895fa6
git #tuleap/stable/0edf674753924bd6fd60b8d5624b7d3f2b9d1411

Modified Files

Side by side diff
Inline diff
Name
A plugins/agiledashboard/tests/e2e/cypress/_fixtures/empty_followup_modal/project.xml +369 −0 Go to diff View file
A plugins/agiledashboard/tests/e2e/cypress/_fixtures/empty_followup_modal/users.xml +35 −0 Go to diff View file
A plugins/agiledashboard/tests/e2e/cypress/cypress/integration/emty_followup_modal.spec.ts +122 −0 Go to diff View file
M plugins/tracker/include/Tracker/Artifact/Presenter/FollowUpCommentsPresenter.php +9 −3 Go to diff View file
M plugins/tracker/include/Tracker/Artifact/Tracker_Artifact_Changeset.class.php +17 −8 Go to diff View file
M plugins/tracker/templates/artifact-modal.mustache +1 −1 Go to diff View file
M plugins/tracker/templates/follow-ups.mustache +1 −1 Go to diff View file
A plugins/tracker/tests/unit/Tracker/Artifact/Presenter/FollowUpCommentsPresenterTest.php +55 −0 Go to diff View file
M plugins/tracker/tests/unit/Tracker_Artifact_ChangesetTest.php +67 −0 Go to diff View file