stable

Clone or download

Read-only

Introduce sections in breadcrumbs

Part of story #11189 have a smart bread crumb This is a preliminary step to be able to display sibling milestones in bread crumbs. Took the oportunity to break the inheritance BreadCrumbItem extends BreadCrumbSubItem. Adjust some styling in order to have proper alignement with section titles. Took the padding of tlp dropdown in order to have same L&F, to please UXD. Apart changes in styling, you should not have functional changes. If you want to test sections without having to wait for sibling milestones, then you can hack AgileDashboardCrumbBuilder::addAdministrationLink() to display some additional sections. Example: $sub_items->addSection( new SubItemsSection( 'Coucou', new BreadCrumbLinkCollection( [ new BreadCrumbLink( $GLOBALS['Language']->getText('global', 'Administration'), $admin_url ) ] ) ) ); $sub_items->addSection( new SubItemsUnlabelledSection( new BreadCrumbLinkCollection( [ new BreadCrumbLink( $GLOBALS['Language']->getText('global', 'Administration'), $admin_url ) ] ) ) ); $sub_items->addSection( new SubItemsSection( 'Coucou', new BreadCrumbLinkCollection( [ new BreadCrumbLink( $GLOBALS['Language']->getText('global', 'Administration'), $admin_url ) ] ) ) ); This should produce the following: +--------------------ˎ | Agile Dashboard › +-----------------+--′ | #Coucou# | | Administration | +-----------------+ | Administration | +-----------------+ | #Coucou# | | Administration | +-----------------+ Change-Id: I8fa9a4788af1f89c0768df77c192cef1e88c4a99

Modified Files

Name
M plugins/agiledashboard/include/AgileDashboard/AdminController.class.php +0 −1 Go to diff View file
M plugins/agiledashboard/include/AgileDashboard/BreadCrumbDropdown/AdministrationCrumbBuilder.php +7 −4 Go to diff View file
M plugins/agiledashboard/include/AgileDashboard/BreadCrumbDropdown/AgileDashboardCrumbBuilder.php +44 −21 Go to diff View file
M plugins/agiledashboard/include/AgileDashboard/BreadCrumbDropdown/MilestoneCrumbBuilder.php +46 −27 Go to diff View file
M plugins/agiledashboard/include/AgileDashboard/BreadCrumbDropdown/VirtualTopMilestoneCrumbBuilder.php +12 −7 Go to diff View file
M plugins/agiledashboard/include/AgileDashboard/Kanban/BreadCrumbBuilder.php +5 −5 Go to diff View file
M plugins/agiledashboard/include/Planning/PlanningController.class.php +0 −1 Go to diff View file
M plugins/agiledashboard/phpunit/AgileDashboard/Planning/MilestoneControllerTest.php +8 −10 Go to diff View file
M src/common/autoload.php +11 −5 Go to diff View file
M src/common/layout/BaseLayout.php +40 −13 Go to diff View file
M src/common/layout/BreadCrumbDropdown/BreadCrumb.php +37 −3 Go to diff View file
R src/common/layout/BreadCrumbDropdown/BreadCrumbItem.php Go to diff View file
R src/common/layout/BreadCrumbDropdown/BreadCrumbSubItem.php Go to diff View file
A src/common/layout/BreadCrumbDropdown/BreadCrumbLinkPresenter.php +51 −0 Go to diff View file
A src/common/layout/BreadCrumbDropdown/BreadCrumbLinkWithIcon.php +33 −0 Go to diff View file
M src/common/layout/BreadCrumbDropdown/BreadCrumbPresenter.php +14 −25 Go to diff View file
M src/common/layout/BreadCrumbDropdown/BreadCrumbPresenterBuilder.php +29 −17 Go to diff View file
R src/common/layout/BreadCrumbDropdown/BreadCrumbSubItemCollection.php Go to diff View file
A src/common/layout/BreadCrumbDropdown/SubItemsSection.php +55 −0 Go to diff View file
A src/common/layout/BreadCrumbDropdown/SubItemsSectionPresenter.php +50 −0 Go to diff View file
A src/common/layout/BreadCrumbDropdown/SubItemsUnlabelledSection.php +29 −0 Go to diff View file
M src/templates/common/breadcrumbs/breadcrumbs.mustache +25 −13 Go to diff View file
M src/www/themes/BurningParrot/BurningParrotTheme.php +2 −3 Go to diff View file
M src/www/themes/BurningParrot/css/includes/_breadcrumb.scss +24 −13 Go to diff View file
M src/www/themes/FlamingParrot/FlamingParrot_Theme.class.php +2 −3 Go to diff View file
M src/www/themes/FlamingParrot/css/utils/_breadcrumb.scss +22 −11 Go to diff View file