Public

Project privacy set to public. By default, its content is available to everyone (authenticated or not). Please note that more restrictive permissions might exist on some items.

stable

Clone or download

Read-only

refactor: Use Flat field checker for cross-tracker too

Download Browse

part of story #10710 search on fields with duck typing No functional change. CI should be happy. Why? It allows us to drop the previous "visitFloat" methods. Unit tests should check that nothing is broken. FloatFieldChecker is merged with FlatFloatFieldChecker so that all the validation logic is in the same file for float fields. Change-Id: Iee4be66273f20f1356474ef4950201285bdd6d35

+129 −135
Joris MASSON (jmasson) 2024-02-20 12:38
Joris MASSON (jmasson) 2024-02-21 10:35
1727c03d8859789b029f7124d2eb85d726dfd79c
b9c800b94872b85ea7c2afdd25223f8017ec208a
git #tuleap/stable/1727c03d8859789b029f7124d2eb85d726dfd79c

Modified Files

Side by side diff
Inline diff
Name
M plugins/crosstracker/include/CrossTracker/Report/Query/Advanced/InvalidTermCollectorVisitor.php +45 −42 Go to diff View file
M plugins/crosstracker/tests/unit/CrossTracker/Tests/Builders/InvalidSearchableCollectorParametersBuilder.php +23 −1 Go to diff View file
M plugins/tracker/include/Tracker/Report/Query/Advanced/InvalidFields/BetweenComparisonVisitor.php +1 −2 Go to diff View file
M plugins/tracker/include/Tracker/Report/Query/Advanced/InvalidFields/CollectionOfAlphaNumericValuesExtractor.php +6 −1 Go to diff View file
M plugins/tracker/include/Tracker/Report/Query/Advanced/InvalidFields/EqualComparisonVisitor.php +1 −2 Go to diff View file
M plugins/tracker/include/Tracker/Report/Query/Advanced/InvalidFields/FlatInvalidFieldChecker.php +2 −2 Go to diff View file
D plugins/tracker/include/Tracker/Report/Query/Advanced/InvalidFields/FloatFields/FlatFloatFieldChecker.php +0 −60 Go to diff View file
M plugins/tracker/include/Tracker/Report/Query/Advanced/InvalidFields/FloatFields/FloatFieldChecker.php +44 −13 Go to diff View file
M plugins/tracker/include/Tracker/Report/Query/Advanced/InvalidFields/GreaterThanComparisonVisitor.php +1 −2 Go to diff View file
M plugins/tracker/include/Tracker/Report/Query/Advanced/InvalidFields/GreaterThanOrEqualComparisonVisitor.php +1 −2 Go to diff View file
M plugins/tracker/include/Tracker/Report/Query/Advanced/InvalidFields/LesserThanComparisonVisitor.php +1 −2 Go to diff View file
M plugins/tracker/include/Tracker/Report/Query/Advanced/InvalidFields/LesserThanOrEqualComparisonVisitor.php +1 −2 Go to diff View file
M plugins/tracker/include/Tracker/Report/Query/Advanced/InvalidFields/NotEqualComparisonVisitor.php +1 −2 Go to diff View file
M plugins/tracker/include/Tracker/Report/Query/Advanced/InvalidTermCollectorVisitor.php +2 −2 Go to diff View file