Public

Project privacy set to public. By default, its content is available to everyone (authenticated or not). Please note that more restrictive permissions might exist on some items.

stable

Clone or download

Read-only

Remove concatenation used to build a SQL query string

Download Browse

It makes things harder to read and nothing should be concatened into a SQL query string without first being escaped. Otherwise, things are harder to audit. In this specific case the concatenation is not useful. This is part of epic #12142: Baseline v1 Change-Id: I76a3b88d19ffdcf1c1d002eec572c906f7888546

+5 −8
Thomas Gerbet (tgerbet) 2019-04-02 14:23
Thomas Gerbet (tgerbet) 2019-04-02 14:23
1aa50707d76ceb126b7eca4ad978852286da7d86
9307e303cdd0d5cc16574f3c67f0423e1f648e4f
git #tuleap/stable/1aa50707d76ceb126b7eca4ad978852286da7d86

Modified Files

Side by side diff
Inline diff
Name
M include/Adapter/BaselineRepositoryAdapter.php +3 −6 Go to diff View file
M phpunit/Adapter/BaselineRepositoryAdapterTest.php +2 −2 Go to diff View file