Public

Project privacy set to public. By default, its content is available to everyone (authenticated or not). Please note that more restrictive permissions might exist on some items.

stable

Clone or download

Read-only

refactor: move interfaces to DAO

Download Browse

Part of story #26799 associate a Tuleap project and a GitLab group No functional change expected. Moving the interfaces down to the DAO lets us unit-test GitlabGroupFactory. We will need to add another check in it, in another contribution. Change-Id: I59b80bd1d79741ac62362ef082b3deba806e9fef

+173 −16
Joris MASSON (jmasson) 2022-09-12 11:09
Joris MASSON (jmasson) 2022-09-12 15:29
2185582b63a96b2275cc215f9c4975943bac9d8c
fb6af3c0e11c2690d36c8236d1fea3dab4d1fc5d
git #tuleap/stable/2185582b63a96b2275cc215f9c4975943bac9d8c

Modified Files

Side by side diff
Inline diff
Name
R plugins/gitlab/include/Group/BuildGitlabGroup.php Go to diff View file
M plugins/gitlab/include/Group/GitlabGroupDAO.php +6 −5 Go to diff View file
M plugins/gitlab/include/Group/GitlabGroupFactory.php +7 −5 Go to diff View file
A plugins/gitlab/include/Group/VerifyGroupIsAlreadyLinked.php +26 −0 Go to diff View file
M plugins/gitlab/include/REST/v1/GitlabGroupResource.php +2 −1 Go to diff View file
M plugins/gitlab/include/Repository/GitlabRepositoryGroupLinkHandler.php +2 −2 Go to diff View file
A plugins/gitlab/tests/unit/Group/GitlabGroupFactoryTest.php +78 −0 Go to diff View file
M plugins/gitlab/tests/unit/Group/GitlabRepositoryGroupLinkHandlerTest.php +6 −2 Go to diff View file
M plugins/gitlab/tests/unit/Group/NewGroupTest.php +1 −1 Go to diff View file
R plugins/gitlab/tests/unit/Test/Stubs/BuildGitlabGroupStub.php Go to diff View file
A plugins/gitlab/tests/unit/Test/Stubs/VerifyGroupIsAlreadyLinkedStub.php +45 −0 Go to diff View file