Public

Project privacy set to public. By default, its content is available to everyone (authenticated or not). Please note that more restrictive permissions might exist on some items.

stable

Clone or download

Read-only

Webhook was not deleted when token is updating

Download Browse

This is part of story #17182: reference tuleap artifacts in gitlab merge requests How to test: - Have an integrated repository with valid token - Revoke this token - Create another token - In the UI, go to your repository in Git service - Update API token => The last webhook is deleted on GitLab server => A new webhook was created => There are no errors in gitlab_syslog Change-Id: I6a43cc66636646bee455ffb82ae013b8baecebc9

+46 −91
Benjamin Bouillot (ben.bouillot) 2021-01-28 15:21
Benjamin Bouillot (ben.bouillot) 2021-01-28 15:21
22ca744531d53e3804d866859fd82111b2485328
24002327d6f947fbbe958767cbdcb31cca19e13b
git #tuleap/stable/22ca744531d53e3804d866859fd82111b2485328

Modified Files

Side by side diff
Inline diff
Name
M plugins/gitlab/include/REST/v1/GitlabRepositoryResource.php +2 −25 Go to diff View file
M plugins/gitlab/include/Repository/GitlabRepositoryDeletor.php +10 −2 Go to diff View file
M plugins/gitlab/include/Repository/Webhook/WebhookCreator.php +1 −1 Go to diff View file
M plugins/gitlab/include/Repository/Webhook/WebhookDeletor.php +5 −11 Go to diff View file
M plugins/gitlab/tests/unit/Repository/GitlabRepositoryDeletorTest.php +18 −2 Go to diff View file
M plugins/gitlab/tests/unit/Repository/Webhook/WebhookCreatorTest.php +5 −17 Go to diff View file
M plugins/gitlab/tests/unit/Repository/Webhook/WebhookDeletorTest.php +5 −33 Go to diff View file