stable
Clone or download
part of request #29602 Migrate pullrequest file-diffs to TypeScript In this contribution, placeholders are now hybrids custom elements. They can be either a code placeholder or a comment placeholder. This improvement had to be made in order to strenghten widgets types. Now we have three types of widgets: - inline-comment widgets - new-inline-comment-widgets - placeholder-widgets Since we had to check in several files wether a given widget is a comment placeholder or a comment widget, these types come in handy and make the code a bit simpler (production and test code). How to test: - No functional change expected, you should have a file diff with properly sized code and comments placeholders, even if you new comments or replies to the file. Change-Id: I02ab9202625da8537b4ed3394f42acd3f4b0fbec
Modified Files
| Name | ||||
|---|---|---|---|---|
| M | plugins/pullrequest/scripts/pullrequests-app/src/app/app.js | +1 | −0 | Go to diff View file |
| M | plugins/pullrequest/scripts/pullrequests-app/src/app/comments/PullRequestComment.ts | +2 | −1 | Go to diff View file |
| A | plugins/pullrequest/scripts/pullrequests-app/src/app/file-diff/FileDiffPlaceholder.test.ts | +77 | −0 | Go to diff View file |
| A | plugins/pullrequest/scripts/pullrequests-app/src/app/file-diff/FileDiffPlaceholder.ts | +53 | −0 | Go to diff View file |
| M | plugins/pullrequest/scripts/pullrequests-app/src/app/file-diff/codemirror-helper-service.js | +4 | −8 | Go to diff View file |
| M | plugins/pullrequest/scripts/pullrequests-app/src/app/file-diff/diff-modes/side-by-side-comment-placeholder-builder.js | +2 | −12 | Go to diff View file |
| M | plugins/pullrequest/scripts/pullrequests-app/src/app/file-diff/diff-modes/side-by-side-comment-placeholder-builder.test.js | +9 | −34 | Go to diff View file |
| M | plugins/pullrequest/scripts/pullrequests-app/src/app/file-diff/diff-modes/side-by-side-comment-placeholder-widget-finder.test.ts | +9 | −16 | Go to diff View file |
| M | plugins/pullrequest/scripts/pullrequests-app/src/app/file-diff/diff-modes/side-by-side-comment-placeholder-widget-finder.ts | +8 | −8 | Go to diff View file |
| M | plugins/pullrequest/scripts/pullrequests-app/src/app/file-diff/diff-modes/side-by-side-diff-component.js | +3 | −3 | Go to diff View file |
| M | plugins/pullrequest/scripts/pullrequests-app/src/app/file-diff/diff-modes/side-by-side-line-height-equalizer.js | +8 | −27 | Go to diff View file |
| M | plugins/pullrequest/scripts/pullrequests-app/src/app/file-diff/diff-modes/side-by-side-line-height-equalizer.test.js | +27 | −127 | Go to diff View file |
| M | plugins/pullrequest/scripts/pullrequests-app/src/app/file-diff/diff-modes/side-by-side-line-widgets-helper.test.ts | +46 | −3 | Go to diff View file |
| M | plugins/pullrequest/scripts/pullrequests-app/src/app/file-diff/diff-modes/side-by-side-line-widgets-helper.ts | +22 | −0 | Go to diff View file |
| M | plugins/pullrequest/scripts/pullrequests-app/src/app/file-diff/diff-modes/types-codemirror-overriden.ts | +2 | −1 | Go to diff View file |
| M | plugins/pullrequest/scripts/pullrequests-app/src/app/file-diff/diff-modes/types.ts | +21 | −0 | Go to diff View file |
| A | plugins/pullrequest/scripts/pullrequests-app/src/app/file-diff/new-inline-comment-component.d.ts | +22 | −0 | Go to diff View file |
| A | plugins/pullrequest/scripts/pullrequests-app/tests/stubs/FileDiffWidgetStub.ts | +69 | −0 | Go to diff View file |