Fixes: request #11530 Replace scss-lint with a nodejs linter How to test: - Try to make a new commit with a new .scss file with this content: .truc { color: #ffffff; margin: 20px 20px; display: flex; } - The pre-commit hook should stop you and give you a command to try to automatically fix those errors. (Not all errors in the config will be auto-fixable though) Rules notes: - Since a majority of our "scss_lint" rules matched them, I chose to extend "stylelint-config-sass-guidelines". For the rules that did not match, our own configuration will override them (for example indentation). - Check [1] for the equivalence between scss_lint rules and stylelint rules. - MergeableSelector is not exactly matched by stylelint. If needed I can spend more time looking for plugins that do this, but I don't think it's a deal-breaker. - UrlFormat has no equivalent. I'm not sure it was such a critical rule however, code review may be enough to spot bad cases. - PropertySortOrder is slightly different, but stylelint can fix that automatically (at last :') ) Performance notes: Stylelint is orders of magnitude faster. To give you an idea, on my machine: time scss-lint . real 11m10.339s time npm run stylelint -- "**/*.scss" user 0m10.612s [1] https://github.com/bjankord/stylelint-config-sass-guidelines/wiki/Lint-Rule-Comparison Might be done later: - Bulk-format all our SCSS files - Convert all //scss-lint:disable comments Change-Id: Ifa38dcf4f8ccbb6a8a40ee616b6f6ee4e9cb9404

+3240 −3009

Author

Joris MASSON (jmasson) 2018-12-06 16:43

Committer

Joris MASSON (jmasson) 2018-12-07 17:59

Hash 278e735867f8247ae2625999bae6c27a17555efb

Parent 19f2a12f2eb8d5925637352727df7d51892b06f3

Reference git #tuleap/stable/278e735867f8247ae2625999bae6c27a17555efb