Public

Project privacy set to public. By default, its content is available to everyone (authenticated or not). Please note that more restrictive permissions might exist on some items.

stable

Clone or download

Read-only

Be sure that classes of Adapter/TopBacklog are never mocked in test

Download Browse

part of request #23433 Clean program management tests No functional changes An easy way to be sure that they won't be mocked is to declare the classes as final Change-Id: If8c2add3b9a36e65f7a3ad0ab7fa31334ec828ba

+394 −100
Marie Ange Garnier (marieange) 2021-10-14 10:10
Marie Ange Garnier (marieange) 2021-10-18 10:57
28baaf1deeeb18d4d7fdd1fa40138c83ff1b3078
f96f8d0c459db9527c8e0024966991d6a68d2435
git #tuleap/stable/28baaf1deeeb18d4d7fdd1fa40138c83ff1b3078

Modified Files

Side by side diff
Inline diff
Name
M plugins/program_management/include/Adapter/Program/Backlog/TopBacklog/Workflow/AddToTopBacklogPostAction.php +3 −13 Go to diff View file
M plugins/program_management/include/Adapter/Program/Backlog/TopBacklog/Workflow/AddToTopBacklogPostActionDAO.php +5 −1 Go to diff View file
M plugins/program_management/include/Adapter/Program/Backlog/TopBacklog/Workflow/AddToTopBacklogPostActionFactory.php +11 −12 Go to diff View file
M plugins/program_management/include/Adapter/Program/Backlog/TopBacklog/Workflow/AddToTopBacklogPostActionValueUpdater.php +6 −15 Go to diff View file
A plugins/program_management/include/Domain/Program/Backlog/TopBacklog/CreatePostAction.php +29 −0 Go to diff View file
A plugins/program_management/include/Domain/Program/Backlog/TopBacklog/DeletePostAction.php +29 −0 Go to diff View file
A plugins/program_management/include/Domain/Program/Backlog/TopBacklog/SearchByTransitionId.php +32 −0 Go to diff View file
A plugins/program_management/include/Domain/Program/Backlog/TopBacklog/SearchByWorkflow.php +32 −0 Go to diff View file
M plugins/program_management/include/program_managementPlugin.php +10 −4 Go to diff View file
M plugins/program_management/tests/unit/Adapter/Program/Backlog/TopBacklog/Workflow/AddToTopBacklogPostActionFactoryTest.php +29 −41 Go to diff View file
M plugins/program_management/tests/unit/Adapter/Program/Backlog/TopBacklog/Workflow/AddToTopBacklogPostActionValueUpdaterTest.php +16 −14 Go to diff View file
A plugins/program_management/tests/unit/Stub/CreatePostActionStub.php +48 −0 Go to diff View file
A plugins/program_management/tests/unit/Stub/DeletePostActionStub.php +48 −0 Go to diff View file
A plugins/program_management/tests/unit/Stub/SearchByTransitionIdStub.php +48 −0 Go to diff View file
A plugins/program_management/tests/unit/Stub/SearchByWorkflowStub.php +48 −0 Go to diff View file