stable

Clone or download

Read-only

Edit package with custom agreement

Manage the license agreements at package creation and update. Rather a big patch as everything is done in one place and there are a lot of configuration to take into account: - License Agreement mandatory or no - Default agreement - Custom agreement or not This patch also slightly change the old behaviour when agreement is mandatory. Until now, a mandatory agreement meant that approval was always set and no options were displayed to end users. However with custom license agreement, another agreement can be selected so we have to deal with this configuration. Part of story #14008 customize FRS Download Agreement in my project Change-Id: I376c3e20b07bf88854f7245ca1b5a85ca3537d54

Modified Files

Name
M plugins/webdav/tests/WebDAVFRSPackageTest.php +18 −54 Go to diff View file
M plugins/webdav/tests/WebDAVFRSReleaseTest.php +11 −16 Go to diff View file
M plugins/webdav/tests/WebDAVFRSTest.php +67 −89 Go to diff View file
M plugins/webdav/tests/WebDAVTreeTest.php +1 −1 Go to diff View file
M site-content/fr_FR/LC_MESSAGES/tuleap-core.po +7 −3 Go to diff View file
M src/common/FRS/FRSPackage.class.php +12 −8 Go to diff View file
M src/common/FRS/FRSPackageController.php +8 −2 Go to diff View file
M src/common/FRS/FRSPackageFactory.class.php +25 −2 Go to diff View file
A src/common/FRS/LicenseAgreement/DefaultLicenseAgreement.php +57 −0 Go to diff View file
A src/common/FRS/LicenseAgreement/EditPackagePresenter.php +45 −0 Go to diff View file
A src/common/FRS/LicenseAgreement/InvalidLicenseAgreementException.php +29 −0 Go to diff View file
M src/common/FRS/LicenseAgreement/LicenseAgreement.php +5 −0 Go to diff View file
M src/common/FRS/LicenseAgreement/LicenseAgreementDao.php +36 −13 Go to diff View file
M src/common/FRS/LicenseAgreement/LicenseAgreementDisplay.php +19 −7 Go to diff View file
M src/common/FRS/LicenseAgreement/LicenseAgreementFactory.php +38 −2 Go to diff View file
M src/common/FRS/LicenseAgreement/LicenseAgreementInterface.php +5 −0 Go to diff View file
A src/common/FRS/LicenseAgreement/LicenseOptionPresenter.php +52 −0 Go to diff View file
R src/common/FRS/LicenseAgreement/NullLicenseAgreement.php Go to diff View file
M src/common/FRS/LicenseAgreement/template/edit-package.mustache +10 −14 Go to diff View file
M src/common/Project/Group.class.php +1 −2 Go to diff View file
M src/www/file/admin/frsajax.php +6 −1 Go to diff View file
M src/www/file/admin/package.php +7 −4 Go to diff View file
M src/www/file/file_utils.php +14 −5 Go to diff View file
R tests/phpunit/common/Frs/FRSFileDownloadControllerTest.php Go to diff View file
R tests/phpunit/common/Frs/FRSFileDownloadOldURLRedirectionControllerTest.php Go to diff View file
R tests/simpletest/common/frs/FRSPackagePermissionManagerTest.php Go to diff View file
R tests/phpunit/common/Frs/FRSPermissionManagerTest.php Go to diff View file
A tests/phpunit/common/FRS/LicenseAgreement/LicenseAgreementDisplayTest.php +182 −0 Go to diff View file
A tests/phpunit/common/FRS/LicenseAgreement/LicenseAgreementFactoryTest.php +114 −0 Go to diff View file
R tests/phpunit/common/Frs/PermissionsPerGroup/PackagePermissionPerGroupRepresentationBuilderTest.php Go to diff View file
R tests/phpunit/common/Frs/PermissionsPerGroup/PermissionPerTypeExtractorTest.php Go to diff View file
M tests/simpletest/common/frs/FRSXMLImporterTest.php +5 −1 Go to diff View file