Public

Project privacy set to public. By default, its content is available to everyone (authenticated or not). Please note that more restrictive permissions might exist on some items.

stable

Clone or download

Read-only

fix: request #27887 Pull-requests on same branches with different references is no more possible

Download Browse

Following the changes done with story #27175, a possible workflow has been broken. Given two branches, main and dev, I can create a pull-request to integrate dev into main. After the merge, I was previously able to add new commits in dev branch and recreate a new pull-request to integrate dev into main. With the work done for story #27175, this is no more possible. How to test ----------- * Create 2 branches in one Git repository (for the exemple we will use dev and main) * Create a pull-resquest to integrate dev into main * Merge the pull-request * Try to recreate the pull-request to integrate dev into main => This creation must fail * Add a few commits into dev * Create a pull-resquest to integrate dev into main => This second creation must work Change-Id: Ieec1ae326a1925080c9ff1a847aac08c8c07b763

+46 −28
Yannis ROSSETTO (rossettoy) 2022-07-22 17:04
Yannis ROSSETTO (rossettoy) 2022-07-25 14:21
306c2adf5b40bb59c929890e81be7f32ed4b8718
572dc6459d7f7181a59a6d28e862759001c19202
git #tuleap/stable/306c2adf5b40bb59c929890e81be7f32ed4b8718

Modified Files

Side by side diff
Inline diff
Name
M plugins/pullrequest/include/PullRequest/Dao.php +10 −4 Go to diff View file
M plugins/pullrequest/include/PullRequest/PullRequestCreator.php +9 −8 Go to diff View file
M plugins/pullrequest/include/PullRequest/PullRequestCreatorChecker.php +9 −5 Go to diff View file
M plugins/pullrequest/tests/unit/PullRequestCreatorCheckerTest.php +18 −11 Go to diff View file