Public

Project privacy set to public. By default, its content is available to everyone (authenticated or not). Please note that more restrictive permissions might exist on some items.

stable

Clone or download

Read-only

fix: Avoid ResizeObserver loop error

Download Browse

How to test: - end-to-end tests for the Artifact modal should succeed. Notes: When you change the size of something during a ResizeObserver callback, it can cause an error because the observer could not report all observations during a single animation frame [0]. Wrapping in `window.requestAnimationFrame()` callback [1] solves this problem: the change of the dropdown position and size comes later than the ResizeObserver callback. It's also a good idea performance-wise. part of story #24971 [modal] search for artifacts [0] https://stackoverflow.com/a/50387233 [1] https://stackoverflow.com/a/58701523 Change-Id: I4895710058beee27ce18fe8333c809e82234285c

+40 −33
Joris MASSON (jmasson) 2022-12-07 14:09
Joris MASSON (jmasson) 2022-12-07 14:15
391e8163922c33976c4c3ec7747cf4b341069b33
70ff92e411b91602446852905fbedc429e374eea
git #tuleap/stable/391e8163922c33976c4c3ec7747cf4b341069b33

Modified Files

Side by side diff
Inline diff
Name
M lib/frontend/link-selector/src/dropdown/DropdownManager.test.ts +5 −3 Go to diff View file
M lib/frontend/link-selector/src/dropdown/DropdownManager.ts +30 −27 Go to diff View file
M lib/frontend/link-selector/src/renderers/BaseComponentRenderer.ts +1 −0 Go to diff View file
M plugins/agiledashboard/tests/e2e/cypress/cypress/e2e/artifact-modal.cy.ts +4 −3 Go to diff View file