Public

Project privacy set to public. By default, its content is available to everyone (authenticated or not). Please note that more restrictive permissions might exist on some items.

stable

Clone or download

Read-only

Renderer of an artifact should truncate the title to 64 chars and not to 64 bytes

Download Browse

Cutting to 64 bytes might cut multibyte characters resulting in weird behaviors (at least not behaviors expected by end users). For example the string "Support multibyte characters on new Tuleap installations 🎆 🦄" is 66 bytes long but only has 60 characters. Cutting it to 64 bytes breaks the 🦄 character resulting in a string that cannot be correctly UTF-8 encoded. If you pass such string to a function like htmlentities() that expects to work in a specific encoding, you end up with an empty string. Part of request #12299: Support multibyte characters on new Tuleap installations 🎆 🦄 Change-Id: Id0da616ad8cfbd085314a8318fcbd2268a8b2b43

+6 −6
Thomas Gerbet (tgerbet) 2020-07-01 19:27
Thomas Gerbet (tgerbet) 2020-07-01 19:52
393979d4b47c686e93c3841312b0c139aaebf872
3d0463c7b9a50a4e9e7d36ecb1d62f7fba491dbf
git #tuleap/stable/393979d4b47c686e93c3841312b0c139aaebf872

Modified Files

Side by side diff
Inline diff
Name
M plugins/git/include/Git/Mirror/MirrorPresenter.php +1 −1 Go to diff View file
M plugins/git/include/GitPHP/git/Commit.php +2 −2 Go to diff View file
M plugins/tracker/include/Tracker/Artifact/Renderer/EditRenderer.class.php +1 −1 Go to diff View file
M plugins/tracker/include/Tracker/CannedResponse/Tracker_CannedResponseManager.class.php +2 −2 Go to diff View file