Public

Project privacy set to public. By default, its content is available to everyone (authenticated or not). Please note that more restrictive permissions might exist on some items.

stable

Clone or download

Read-only

Refactor Transition->getWorkflow()

Download Browse

Part of story #12187 configure workflow pre & post actions at target state level Throw dedicateed exception when trying to get transition's workflow. Some callers checked null before throwing OrphanTransitionException. All other does not check null. More over, a transition without workflow is due to inconsistent database. So, throwing this exception earlier will prevent code duplication with checking null in all callers. Change-Id: Ide7dee09eb685446581977644a84c99a2167c8ef

+21 −29
Jean-Baptiste Mille (jibidus) 2018-12-31 15:59
Jean-Baptiste Mille (jibidus) 2019-01-02 17:12
3c10192c682a3b66489f548ea5443963eaf2c707
f92fd989199a1ba35c2534c387b21e5152b15a75
git #tuleap/stable/3c10192c682a3b66489f548ea5443963eaf2c707

Modified Files

Side by side diff
Inline diff
Name
M plugins/tracker/include/REST/v1/Workflow/TransitionRepresentationBuilder.php +2 −5 Go to diff View file
M plugins/tracker/include/REST/v1/Workflow/TransitionsPermissionsChecker.php +3 −10 Go to diff View file
M plugins/tracker/include/REST/v1/Workflow/TransitionsResource.class.php +3 −10 Go to diff View file
M plugins/tracker/include/workflow/Transition.class.php +13 −4 Go to diff View file
R plugins/tracker/include/REST/v1/Workflow/OrphanTransitionException.php Go to diff View file