stable

Clone or download

Read-only

Remove @tuleap/mention from rich-text-editor

Part of story #18337 markdown replace text Introduced by git #tuleap/stable/79006cffc3668c24828a233bd4de74e648072ab9 Issue has been spotted by cypress end-to-end tests in the artifact modal. How to test: - Rebuild rich-text-editor, Trackers plugin and AgileDashboard plugin - "artifact-modal" end-to-end test should pass - In Tracker Artifact view, users can autocomplete @usernames in: - New artifact creation view (text fields) - Existing artifact edition view (text fields, new comment, edition of existing comment) - In the Artifact modal (in Kanban or Planning view), users **cannot** autocomplete @usernames. Notes: As expected, @tuleap/mention is completely broken with a recent jQuery / BurningParrot. Not only that, but it *also* breaks Select2. To fix this situation, we'll break the dependency from @tuleap/plugin-tracker-rich-text-editor to @tuleap/mention. RTE will offer a callback that the Trackers plugin code will provide, so that only Tracker Artifact view uses @tuleap/mention. As a result, the Artifact modal will not support @mentions (but it never did). @mentions also never worked in mass-change's new follow-up comment, so it is not added now. @mentions also did not work in TTM step fields, so support is not added now. Change-Id: I1b67a924c934f6dada2f50f743f3bcfcfaef13ef

Modified Files

Name
M plugins/tracker/scripts/artifact/rich-text-editor-creator/RichTextEditorsCreator.test.ts +5 −0 Go to diff View file
M plugins/tracker/scripts/artifact/rich-text-editor-creator/RichTextEditorsCreator.ts +3 −0 Go to diff View file
A plugins/tracker/scripts/artifact/rich-text-editor-creator/init-mentions.ts +28 −0 Go to diff View file
M plugins/tracker/scripts/lib/rich-text-editor/README.md +4 −0 Go to diff View file
M plugins/tracker/scripts/lib/rich-text-editor/package.json +0 −1 Go to diff View file
M plugins/tracker/scripts/lib/rich-text-editor/src/TextEditor.test.ts +11 −20 Go to diff View file
M plugins/tracker/scripts/lib/rich-text-editor/src/TextEditor.ts +1 −8 Go to diff View file
M plugins/tracker/scripts/lib/rich-text-editor/src/options-defaulter.test.ts +5 −0 Go to diff View file
M plugins/tracker/scripts/lib/rich-text-editor/src/options-defaulter.ts +1 −0 Go to diff View file
M plugins/tracker/scripts/lib/rich-text-editor/src/types.ts +3 −0 Go to diff View file