Public

Project privacy set to public. By default, its content is available to everyone (authenticated or not). Please note that more restrictive permissions might exist on some items.

stable

Clone or download

Read-only

refactoring: Introduce a Facade interface for field values

Download Browse

part of request #22231 Decrease adapter responsibility No functional change expected when creating mirror program increments. You can use cypress tests for non-regression. It groups together the "Retrieve field values" interfaces and lets us pass the retriever only once. Change-Id: Ib6e8e5b8ba22b5b93227c8a73555f76d94fa527f

+132 −58
Joris MASSON (jmasson) 2021-08-13 16:18
Joris MASSON (jmasson) 2021-08-17 10:10
40056c583180bf30f34bb4a7e98253a425e4c802
b47ae72e104cc7a28a530013fe7bacc1c8a433b2
git #tuleap/stable/40056c583180bf30f34bb4a7e98253a425e4c802

Modified Files

Side by side diff
Inline diff
Name
M plugins/program_management/include/Adapter/Program/Backlog/AsynchronousCreation/TaskBuilder.php +1 −6 Go to diff View file
M plugins/program_management/include/Adapter/Program/Backlog/ProgramIncrement/Source/Changeset/Values/ArtifactFieldValuesRetriever.php +2 −5 Go to diff View file
M plugins/program_management/include/Adapter/Program/Backlog/ProgramIncrement/SourceChangesetValuesCollectionAdapter.php +8 −20 Go to diff View file
A plugins/program_management/include/Domain/Program/Backlog/ProgramIncrement/Source/Changeset/Values/GatherFieldValues.php +27 −0 Go to diff View file
M plugins/program_management/tests/unit/Adapter/Program/Backlog/ProgramIncrement/SourceChangesetValuesCollectionAdapterTest.php +9 −27 Go to diff View file
A plugins/program_management/tests/unit/Stub/GatherFieldValuesStub.php +85 −0 Go to diff View file