Public

Project privacy set to public. By default, its content is available to everyone (authenticated or not). Please note that more restrictive permissions might exist on some items.

stable

Clone or download

Read-only

Split Search and Retrieve Program Increments

Download Browse

part of: story #21385 display Program's iterations No functional change expected. Search* interfaces return arrays of objects (possibly empty). Retrieve* interfaces return one or zero result (an object that may be null). Splitting the two allows for easier reuse. This patch also removes some redundant checks. For example there is no need to check if a ProgramIncrementIdentifier can be seen by the user: it's been done already. Change-Id: Ia533acc76ecf69f14a6d327fdd37439e1d4994b3

+453 −477
Joris MASSON (jmasson) 2021-11-08 18:06
Joris MASSON (jmasson) 2021-11-09 10:09
449b62c498a60cc31a0adacfce14e2811c65be1c
979227298cc5ee7728da5ba9110074e510e0d182
git #tuleap/stable/449b62c498a60cc31a0adacfce14e2811c65be1c

Modified Files

Side by side diff
Inline diff
Name
M plugins/program_management/include/Adapter/Program/Backlog/ProgramIncrement/ProgramIncrementInfoBuilder.php +2 −2 Go to diff View file
A plugins/program_management/include/Adapter/Program/Backlog/ProgramIncrement/ProgramIncrementRetriever.php +66 −0 Go to diff View file
M plugins/program_management/include/Adapter/Program/Backlog/ProgramIncrement/ProgramIncrementsDAO.php +6 −7 Go to diff View file
D plugins/program_management/include/Adapter/Program/Backlog/ProgramIncrement/ProgramIncrementsRetriever.php +0 −145 Go to diff View file
D plugins/program_management/include/Domain/Program/Backlog/ProgramIncrement/ProgramIncrementBuilder.php +0 −53 Go to diff View file
A plugins/program_management/include/Domain/Program/Backlog/ProgramIncrement/ProgramIncrementsSearcher.php +98 −0 Go to diff View file
R plugins/program_management/include/Domain/Program/Backlog/ProgramIncrement/RetrieveProgramIncrements.php Go to diff View file
A plugins/program_management/include/Domain/Program/Backlog/ProgramIncrement/SearchOpenProgramIncrements.php +33 −0 Go to diff View file
R plugins/program_management/include/Domain/Program/Backlog/ProgramIncrementTracker/SearchOpenProgramIncrement.php Go to diff View file
M plugins/program_management/include/REST/v1/ProjectResource.php +10 −11 Go to diff View file
M plugins/program_management/include/program_managementPlugin.php +2 −7 Go to diff View file
M plugins/program_management/tests/unit/Adapter/Program/Backlog/ProgramIncrement/ProgramIncrementInfoBuilderTest.php +5 −5 Go to diff View file
A plugins/program_management/tests/unit/Adapter/Program/Backlog/ProgramIncrement/ProgramIncrementRetrieverTest.php +87 −0 Go to diff View file
D plugins/program_management/tests/unit/Adapter/Program/Backlog/ProgramIncrement/ProgramIncrementsRetrieverTest.php +0 −196 Go to diff View file
M plugins/program_management/tests/unit/Builder/ProgramIncrementBuilder.php +1 −5 Go to diff View file
D plugins/program_management/tests/unit/Domain/Program/Backlog/ProgramIncrement/ProgramIncrementBuilderTest.php +0 −46 Go to diff View file
A plugins/program_management/tests/unit/Domain/Program/Backlog/ProgramIncrement/ProgramIncrementsSearcherTest.php +96 −0 Go to diff View file
R plugins/program_management/tests/unit/Stub/RetrieveProgramIncrementsStub.php Go to diff View file
A plugins/program_management/tests/unit/Stub/SearchOpenProgramIncrementsStub.php +47 −0 Go to diff View file
R plugins/program_management/tests/unit/Stub/SearchOpenProgramIncrementStub.php Go to diff View file