Public

Project privacy set to public. By default, its content is available to everyone (authenticated or not). Please note that more restrictive permissions might exist on some items.

stable

Clone or download

Read-only

request #12630: PR creation failure due to a Git reference creation failure is marked as a user error

Download Browse

If a Git operation fails when a user ask for the creation of the PR, the error is marked as user error and the REST API returns a 400. If a Git operation the error is not server side not client side therefore a 400 is not appropriate. It also means we get no log and we have no way to debug the underlying issue. Change-Id: Ia7d4e0a99c9731fb4360bc7496774c53da7d385c

+33 −2
Thomas Gerbet (tgerbet) 2018-12-17 12:15
Thomas Gerbet (tgerbet) 2018-12-17 12:15
450080cdd22381bae0968eb4a6493725a649afe9
76fc7ff46832dcc60cfd5ddcb244457ebbacde71
git #tuleap/stable/450080cdd22381bae0968eb4a6493725a649afe9

Modified Files

Side by side diff
Inline diff
Name
A plugins/pullrequest/include/PullRequest/Exception/PullRequestTargetException.php +29 −0 Go to diff View file
M plugins/pullrequest/include/PullRequest/PullRequestCreator.php +2 −1 Go to diff View file
M plugins/pullrequest/include/PullRequest/REST/v1/PullRequestsResource.php +2 −1 Go to diff View file