stable
Clone or download
Read-only
A REST representation of the plugin makes a references to a class located in a tests directory. This is not shipped in production (and not added to the autoloader). Due to that Restler is not able to properly parse all the routes and it crashes without logging anything. To prevent similar future issues this contribution makes sure production code cannot reference "test" code thanks to Deptrac. Psalm baseline has been re-created to accomodate with the changes related to the usage of \DataAccessResult. Part of story #26042: install mediawiki standalone Change-Id: If49d88a9ff1390f697e20c7e1f143ad4d84af728
Modified Files
| Name | ||||
|---|---|---|---|---|
| M | plugins/agiledashboard/include/AgileDashboard/BacklogItem/SubBacklogItemProvider.class.php | +1 | −1 | Go to diff View file |
| M | plugins/agiledashboard/include/AgileDashboard/Planning/PlanningDao.php | +1 | −1 | Go to diff View file |
| M | plugins/cardwall/include/OnTop/ColumnDao.class.php | +1 | −1 | Go to diff View file |
| M | plugins/docman/include/ApprovalTable/Item/ItemDao.class.php | +1 | −1 | Go to diff View file |
| M | plugins/docman/include/Docman_ItemDao.class.php | +6 | −6 | Go to diff View file |
| M | plugins/docman/include/Docman_LinkVersionDao.class.php | +2 | −2 | Go to diff View file |
| M | plugins/docman/include/Docman_LockDao.class.php | +3 | −3 | Go to diff View file |
| M | plugins/docman/include/Docman_LockFactory.class.php | +2 | −2 | Go to diff View file |
| M | plugins/docman/include/Docman_LogDao.class.php | +2 | −2 | Go to diff View file |
| M | plugins/docman/include/Docman_NotificationsManager.class.php | +2 | −1 | Go to diff View file |
| M | plugins/docman/include/Docman_PermissionsManagerDao.class.php | +1 | −1 | Go to diff View file |
| M | plugins/docman/include/Docman_TokenDao.class.php | +1 | −1 | Go to diff View file |
| M | plugins/docman/include/Docman_VersionDao.class.php | +15 | −15 | Go to diff View file |
| M | plugins/docman/include/Notifications/UsersToNotifyDao.php | +2 | −3 | Go to diff View file |
| M | plugins/git/include/Git/Ci/Dao.class.php | +4 | −4 | Go to diff View file |
| M | plugins/git/include/Git/Gitolite/SSHKey/Provider/User.php | +1 | −1 | Go to diff View file |
| M | plugins/git/include/GitRepositoryPermissionsManager.class.php | +1 | −1 | Go to diff View file |
| M | plugins/git/include/Git_LogDao.class.php | +1 | −1 | Go to diff View file |
| M | plugins/git/include/Git_PostReceiveMailDao.class.php | +1 | −1 | Go to diff View file |
| M | plugins/hudson/include/PluginHudsonJobDao.class.php | +6 | −6 | Go to diff View file |
| M | plugins/ldap/include/LDAP_DirectoryCleanUpDao.class.php | +2 | −2 | Go to diff View file |
| M | plugins/ldap/include/LDAP_UserDao.class.php | +3 | −1 | Go to diff View file |
| M | plugins/ldap/include/LDAP_UserGroupDao.class.php | +1 | −1 | Go to diff View file |
| M | plugins/ldap/include/LDAP_UserGroupManager.class.php | +1 | −1 | Go to diff View file |
| M | plugins/ldap/include/LDAP_UserManager.class.php | +1 | −1 | Go to diff View file |
| R | plugins/mediawiki_standalone/tests/unit/Permissions/UserPermissions.php | Go to diff View file | ||
| M | plugins/projectlinks/include/ProjectLinksDao.class.php | +3 | −3 | Go to diff View file |
| M | plugins/statistics/include/Statistics_DiskUsageDao.class.php | +4 | −4 | Go to diff View file |
| M | plugins/statistics/include/Statistics_ProjectQuotaDao.class.php | +2 | −2 | Go to diff View file |
| M | plugins/statistics/include/Statistics_ScmCvsDao.class.php | +7 | −7 | Go to diff View file |
| M | plugins/statistics/include/Statistics_ScmSvnDao.class.php | +7 | −7 | Go to diff View file |
| M | plugins/statistics/include/Statistics_Services_UsageFormatter.class.php | +2 | −2 | Go to diff View file |
| M | plugins/svn/include/SVN/Dao.php | +1 | −1 | Go to diff View file |
| M | plugins/testmanagement/include/TestManagement/Dao.class.php | +1 | −1 | Go to diff View file |
| M | plugins/testmanagement/include/TestManagement/REST/v1/ArtifactNodeDao.php | +4 | −4 | Go to diff View file |
| M | plugins/testmanagement/include/TestManagement/Step/Definition/Field/StepDefinitionChangesetValueDao.php | +1 | −1 | Go to diff View file |
| M | plugins/testmanagement/include/TestManagement/Step/Execution/Field/StepExecutionChangesetValueDao.php | +1 | −1 | Go to diff View file |
| M | plugins/tracker/include/Tracker/Artifact/RecentlyVisited/RecentlyVisitedDao.php | +1 | −1 | Go to diff View file |
| M | plugins/tracker/include/Tracker/Artifact/dao/Tracker_ArtifactDao.class.php | +10 | −10 | Go to diff View file |
| M | plugins/tracker/include/Tracker/Artifact/dao/Tracker_Artifact_ChangesetDao.class.php | +2 | −2 | Go to diff View file |
| M | plugins/tracker/include/Tracker/DateReminder/dao/Tracker_DateReminderDao.class.php | +5 | −5 | Go to diff View file |
| M | plugins/tracker/include/Tracker/FormElement/Field/Burndown/BurndownFieldDao.php | +1 | −2 | Go to diff View file |
| M | plugins/tracker/include/Tracker/FormElement/Field/Computed/ComputedFieldDao.php | +2 | −3 | Go to diff View file |
| M | plugins/tracker/include/Tracker/FormElement/Field/FieldDao.php | +3 | −4 | Go to diff View file |
| M | plugins/tracker/include/Tracker/FormElement/Field/PermissionsOnArtifact/PermissionsOnArtifactFieldValueDao.php | +1 | −1 | Go to diff View file |
| M | plugins/tracker/include/Tracker/FormElement/Field/StringField/StringFieldDao.php | +1 | −1 | Go to diff View file |
| M | plugins/tracker/include/Tracker/FormElement/Tracker_FormElementFactory.php | +2 | −2 | Go to diff View file |
| M | plugins/tracker/include/Tracker/FormElement/Tracker_FormElement_Field.php | +2 | −1 | Go to diff View file |
| M | plugins/tracker/include/Tracker/Report/dao/Tracker_ReportDao.class.php | +1 | −1 | Go to diff View file |
| M | plugins/tracker/include/Tracker/Rule/dao/Tracker_RuleDao.class.php | +3 | −3 | Go to diff View file |
| M | plugins/tracker/include/Tracker/Semantic/dao/IRetrieveSemanticDARByTracker.class.php | +3 | −1 | Go to diff View file |
| M | plugins/tracker/include/Tracker/dao/TrackerDao.class.php | +3 | −2 | Go to diff View file |
| M | plugins/tracker/include/Tracker/dao/Tracker_FileInfoDao.class.php | +1 | −1 | Go to diff View file |
| M | plugins/tracker/include/Tracker/dao/Tracker_GlobalNotificationDao.class.php | +6 | −6 | Go to diff View file |
| M | plugins/tracker/include/Workflow/PostAction/CIBuild/Transition_PostAction_CIBuildDao.class.php | +1 | −1 | Go to diff View file |
| M | plugins/tracker/include/Workflow/PostAction/Field/dao/Transition_PostAction_FieldDao.class.php | +6 | −4 | Go to diff View file |
| M | plugins/tracker/include/Workflow/Transition/Condition/FieldNotEmpty/Dao.class.php | +1 | −1 | Go to diff View file |
| M | plugins/tracker/include/Workflow/Transition/Condition/Permissions.class.php | +1 | −1 | Go to diff View file |
| M | src/common/Dashboard/Project/ProjectDashboardDao.php | +2 | −2 | Go to diff View file |
| M | src/common/FRS/FRSFileFactory.class.php | +4 | −3 | Go to diff View file |
| M | src/common/FRS/FileModuleMonitorFactory.class.php | +2 | −2 | Go to diff View file |
| M | src/common/Label/LabelableDao.php | +3 | −1 | Go to diff View file |
| M | src/common/Project/CustomDescription/CustomDescriptionDao.class.php | +3 | −3 | Go to diff View file |
| M | src/common/Project/ProjectManager.class.php | +3 | −3 | Go to diff View file |
| M | src/common/Project/ProjectUGroup.php | +1 | −1 | Go to diff View file |
| M | src/common/Project/Service/ServiceUsageDao.class.php | +2 | −2 | Go to diff View file |
| M | src/common/Project/UGroupManager.class.php | +4 | −4 | Go to diff View file |
| M | src/common/Project/Webhook/Log/WebhookLoggerDao.php | +1 | −1 | Go to diff View file |
| M | src/common/Project/Webhook/WebhookDao.php | +1 | −1 | Go to diff View file |
| M | src/common/SVNCore/SvnNotification.class.php | +1 | −1 | Go to diff View file |
| M | src/common/admin/Homepage/Dao.php | +1 | −1 | Go to diff View file |
| M | src/common/dao/ArtifactFieldDao.class.php | +2 | −2 | Go to diff View file |
| M | src/common/dao/ArtifactGlobalNotificationDao.class.php | +6 | −6 | Go to diff View file |
| M | src/common/dao/ArtifactRuleDao.class.php | +9 | −9 | Go to diff View file |
| M | src/common/dao/FRSFileDao.class.php | +5 | −5 | Go to diff View file |
| M | src/common/dao/FRSPackageDao.class.php | +2 | −2 | Go to diff View file |
| M | src/common/dao/FRSReleaseDao.class.php | +2 | −2 | Go to diff View file |
| M | src/common/dao/FeedbackDao.class.php | +1 | −1 | Go to diff View file |
| M | src/common/dao/FileModuleMonitorDao.class.php | +2 | −2 | Go to diff View file |
| M | src/common/dao/MailingListDao.class.php | +5 | −5 | Go to diff View file |
| M | src/common/dao/PermissionsDao.class.php | +5 | −5 | Go to diff View file |
| M | src/common/dao/PluginDao.class.php | +6 | −4 | Go to diff View file |
| M | src/common/dao/ProjectDao.class.php | +3 | −3 | Go to diff View file |
| M | src/common/dao/ProjectHierarchyDao.class.php | +2 | −2 | Go to diff View file |
| M | src/common/dao/ProjectHistoryDao.class.php | +1 | −3 | Go to diff View file |
| M | src/common/dao/ReferenceDao.class.php | +12 | −12 | Go to diff View file |
| M | src/common/dao/ServiceDao.class.php | +1 | −1 | Go to diff View file |
| M | src/common/dao/SvnNotificationDao.class.php | +1 | −1 | Go to diff View file |
| M | src/common/dao/SystemEventDao.class.php | +5 | −5 | Go to diff View file |
| M | src/common/dao/UGroupDao.class.php | +7 | −7 | Go to diff View file |
| M | src/common/dao/UGroupUserDao.class.php | +6 | −6 | Go to diff View file |
| M | src/common/dao/UserDao.class.php | +10 | −10 | Go to diff View file |
| M | src/common/dao/UserGroupDao.class.php | +7 | −5 | Go to diff View file |
| M | src/common/dao/include/DataAccessObject.class.php | +1 | −3 | Go to diff View file |
| M | src/common/permission/PermissionsManager.class.php | +2 | −2 | Go to diff View file |
| M | src/common/wiki/lib/WikiAttachment.class.php | +3 | −1 | Go to diff View file |
| M | src/common/wiki/lib/WikiAttachmentDao.class.php | +7 | −5 | Go to diff View file |
| A | tests/deptrac/no_dependency_to_tests_in_prod_skip_uncovered.yml | +25 | −0 | Go to diff View file |
| M | tests/psalm/tuleap-baseline.xml | +8549 | −9034 | Go to diff View file |