stable

Clone or download

Read-only

refactor: Remove last usages of Tracker_ArtifactFactory::createArtifact

No functional changes in artifact creation in the web ui (submit new artifact, or via the modal v1 in artifact links). This was the last usages, the method can be safely removed from `Tracker_ArtifactFactory`. We now have [the following flow to create an artifact][0]: ```mermaid flowchart LR A[ArtifactCreator::create !Transaction!]--> D[TrackerArtifactCreator::create] H[ArtifactCreator::createWithValuesIndexedByFieldName !Transaction!]-->D C[Tracker::importFromCSV]-->D I[Tracker_Action_CreateArtifact::createArtifact]-->D J[Tracker_Action_CreateArtifactFromModal::createArtifact]-->D K[Tracker_Artifact_MailGateway_MailGateway::createArtifact]-->D E[ArtifactCreatorAdapter program]-->D L[IterationsCreator::createOneIteration]-->E M[ProgramIncrementsCreator::createOneProgramIncrement]-->E D-->F[TrackerArtifactCreator::createFirstChangesetNoValidation !Transaction!] F-->G[Plugins: ArtifactCreated!] ``` [0]: https://mermaid.live/edit#pako:eNqFkkFuwjAQRa-Seg0X8KJSmhCaFigqFV0kCI3iCbHq2JHjiCLELbrvqvfrEeoQQlMENKuJ5v_3xx5vSaIYEkpSodZJBto4o-dYOvZzI1cbnkJiPI1glKY0qQv8_vz4WvT7t44fvWhI3lBfEC4a0P0l0Cs32RxEhWUoGb4ju9sEHAWbQH4M8RuG10ZRyvNCaRNolXuzeUcStpKlmxiu5HKfhm12G9r-d5wP15111FgxEFcQj7-IQ3M5Bi6GVr2GTbc-C3EayuD0plwGhUHtFFqtNOSdwFEU2gbU45Yn1_ok8dirHYPGMY6mDSWUVpejNGeMp5KO37dl8M_GA65L42UgV1iimSi7Xc72g-z3aSkNK7CsYTQV1YrLkjp_aMhuFqRHctQ5cGaf5rb2xMRkdqKYUFsyTKESJiax3FkpVEbNNjIh1OgKe6QqbCb6HOqjEJqCKHH3AzQ3Cw4 Part of request #36805: Kanban item not found when creating a card in Kanban Change-Id: I0b7be91274f0f3fa3dd3e68a427673ff39ac0678

Modified Files

Name
M plugins/tracker/include/Tracker/Action/CreateArtifact.class.php +14 −11 Go to diff View file
M plugins/tracker/include/Tracker/Action/CreateArtifactFromModal.class.php +16 −15 Go to diff View file
M plugins/tracker/include/Tracker/Artifact/Tracker_ArtifactFactory.class.php +0 −45 Go to diff View file
M plugins/tracker/include/Tracker/Tracker.class.php +2 −1 Go to diff View file
M plugins/tracker/tests/unit/Tracker/Action/Tracker_Action_CreateArtifactTest.php +2 −0 Go to diff View file