stable

Clone or download

Read-only

refactor: Group Description invalid checks together

Part of story #36833 search on semantics and always there fields even if not defined No functional change. CI should be happy. Notes: I reused the same "checker" as Title, as the checks are exactly the same for both. Why ? This is part of the refactoring of the structure of the query validation to transition away from checks being grouped by comparison type (equals, lesser than, etc). We want to group checks by semantic / field type instead, as it is easier to understand. Most of the time, we work "field by field", so it makes more sense to have all the business rules for a given field in as few files as possible, instead of having all the business rules for "equals" comparisons being grouped together. Furthermore, usage of inheritance makes it hard to keep a mental model of the validation rules for a given field. Change-Id: Ic286f97a1d402da8245d9fa331b8ad4055587a88

Modified Files

Name
M plugins/crosstracker/include/CrossTracker/REST/v1/CrossTrackerReportsResource.php +2 −2 Go to diff View file
M plugins/crosstracker/include/CrossTracker/Report/Query/Advanced/QueryValidation/Metadata/FlatInvalidMetadataChecker.php +3 −3 Go to diff View file
R plugins/crosstracker/include/CrossTracker/Report/Query/Advanced/QueryValidation/Metadata/TitleChecker.php Go to diff View file
M plugins/crosstracker/include/crosstrackerPlugin.php +2 −2 Go to diff View file
M plugins/crosstracker/tests/integration/CrossTracker/Tests/Report/ArtifactReportFactoryInstantiator.php +2 −2 Go to diff View file
M plugins/crosstracker/tests/unit/CrossTracker/Report/Query/Advanced/InvalidTermCollectorVisitorTest.php +2 −2 Go to diff View file