stable

Clone or download

Read-only

Replace deprecated sniff UnusedPrivateElements by Psalm

Only the detection of unused properties has been enabled for now (but this was most of the work the sniff was doing anyway). Since this require a run on the full sources it is only played in the nightly pipeline. A few fixes have been made to allow Psalm to properly analyze the code. The GitActions class has been excluded, some properties are seen as non used even so they are. This class is in a state that can be qualified of hopeless so this should be good enough ¯\_(ツ)_/¯. Part of request #19183: Update PHP coding standard tooling Change-Id: I0e5e595953bc4359041ff467ac03a037a75c09a3

Modified Files

Name
M Makefile +4 −0 Go to diff View file
M plugins/agiledashboard/include/AgileDashboard/REST/v1/ProjectBacklogResource.class.php +6 −13 Go to diff View file
M plugins/docman/include/REST/v1/DocmanItemsResource.php +1 −6 Go to diff View file
M plugins/docman/include/REST/v1/DocmanWikiResource.php +1 −6 Go to diff View file
M plugins/git/include/Git.class.php +5 −1 Go to diff View file
M plugins/git/include/Git/Driver/Gerrit/Template/Template.class.php +1 −3 Go to diff View file
M plugins/git/include/Git/Hook/LogAnalyzer.class.php +3 −9 Go to diff View file
M plugins/git/include/GitActions.class.php +32 −33 Go to diff View file
M plugins/git/include/GitRepositoryFactory.class.php +1 −1 Go to diff View file
M plugins/git/include/Git_GitoliteDriver.class.php +16 −42 Go to diff View file
M plugins/git/include/SystemEvents/SystemEvent_GIT_REPO_DELETE.class.php +4 −0 Go to diff View file
M plugins/git/include/SystemEvents/SystemEvent_GIT_REPO_RESTORE.class.php +6 −1 Go to diff View file
M plugins/git/include/mvc/PluginActions.class.php +9 −4 Go to diff View file
M plugins/hudson_git/include/HudsonGit/REST/v1/GitJenkinsServersResource.php +4 −12 Go to diff View file
M plugins/pluginsadministration/include/PluginsAdministrationViews.class.php +0 −1 Go to diff View file
M plugins/svn/include/SVN/Hooks/PreCommit.php +1 −5 Go to diff View file
M plugins/testmanagement/include/TestManagement/REST/v1/NodeBuilderFactory.php +2 −6 Go to diff View file
M plugins/tracker/include/Tracker/Artifact/RecentlyVisited/VisitRetriever.php +10 −2 Go to diff View file
M plugins/tracker/include/Tracker/Artifact/Tracker_ArtifactLinkInfo.class.php +1 −1 Go to diff View file
M plugins/tracker/include/Tracker/Artifact/XMLImport/ArtifactFieldsDataBuilder.class.php +2 −10 Go to diff View file
M plugins/tracker/include/Tracker/Notifications/TrackerForceNotificationsLevelCommand.php +1 −0 Go to diff View file
M plugins/tracker/include/Tracker/Report/Query/Advanced/UgroupLabelConverter.php +2 −8 Go to diff View file
M plugins/tracker/include/Tracker/Report/Tracker_Report_Renderer.class.php +3 −0 Go to diff View file
M src/common/Project/Admin/ProjectVisibilityPresenter.class.php +3 −8 Go to diff View file
M src/common/Project/XML/Import/ZipArchive.php +2 −4 Go to diff View file
M src/common/User/Admin/UserChangePasswordPresenter.php +2 −6 Go to diff View file
M src/embedded_vendor/jpgraph/jpgraph.php +0 −1 Go to diff View file
M src/embedded_vendor/jpgraph/jpgraph_text.inc.php +2 −2 Go to diff View file
M tests/Jenkinsfile-nightly +19 −0 Go to diff View file
M tests/actions.groovy +11 −0 Go to diff View file
M tests/phpcs/non-psr-rules.xml +0 −2 Go to diff View file
M tests/psalm/psalm.xml +20 −0 Go to diff View file