Public

Project privacy set to public. By default, its content is available to everyone (authenticated or not). Please note that more restrictive permissions might exist on some items.

stable

Clone or download

Read-only

request #13472: Forbid late static binding with constants

Download Browse

LSB with constants is confusing and makes harder for implementations to determine which parts of the contract set by the interface/class needs to be fulfilled. Abstract methods can be used to achieve the same thing. This contribution fixes the only usage of it in the codebase and updates the coding standards to block new usages. Change-Id: Ibebdc3f48e4335abfbd4474baacc7bb87fbdae35

+77 −32
Thomas Gerbet (tgerbet) 2019-06-07 13:17
Thomas Gerbet (tgerbet) 2019-06-07 13:17
4f6598b24f29ed68174f21afaec12f1bf2c0d120
22c147d37c8906fa5041470650426a712100e5ac
git #tuleap/stable/4f6598b24f29ed68174f21afaec12f1bf2c0d120

Modified Files

Side by side diff
Inline diff
Name
M plugins/crosstracker/include/CrossTracker/Report/Query/Advanced/QueryValidation/Comparison/Between/BetweenComparisonChecker.php +9 −4 Go to diff View file
M plugins/crosstracker/include/CrossTracker/Report/Query/Advanced/QueryValidation/Comparison/ComparisonChecker.php +6 −6 Go to diff View file
M plugins/crosstracker/include/CrossTracker/Report/Query/Advanced/QueryValidation/Comparison/Equal/EqualComparisonChecker.php +8 −3 Go to diff View file
M plugins/crosstracker/include/CrossTracker/Report/Query/Advanced/QueryValidation/Comparison/GreaterOrLesserThanComparisonChecker.php +3 −5 Go to diff View file
M plugins/crosstracker/include/CrossTracker/Report/Query/Advanced/QueryValidation/Comparison/GreaterThan/GreaterThanComparisonChecker.php +7 −2 Go to diff View file
M plugins/crosstracker/include/CrossTracker/Report/Query/Advanced/QueryValidation/Comparison/GreaterThan/GreaterThanOrEqualComparisonChecker.php +6 −1 Go to diff View file
M plugins/crosstracker/include/CrossTracker/Report/Query/Advanced/QueryValidation/Comparison/In/InComparisonChecker.php +7 −2 Go to diff View file
M plugins/crosstracker/include/CrossTracker/Report/Query/Advanced/QueryValidation/Comparison/LesserThan/LesserThanComparisonChecker.php +7 −2 Go to diff View file
M plugins/crosstracker/include/CrossTracker/Report/Query/Advanced/QueryValidation/Comparison/LesserThan/LesserThanOrEqualComparisonChecker.php +7 −2 Go to diff View file
M plugins/crosstracker/include/CrossTracker/Report/Query/Advanced/QueryValidation/Comparison/NotEqual/NotEqualComparisonChecker.php +8 −3 Go to diff View file
M plugins/crosstracker/include/CrossTracker/Report/Query/Advanced/QueryValidation/Comparison/NotIn/NotInComparisonChecker.php +7 −2 Go to diff View file
M tests/phpcs/tuleap-ruleset-minimal.xml +2 −0 Go to diff View file