Public

Project privacy set to public. By default, its content is available to everyone (authenticated or not). Please note that more restrictive permissions might exist on some items.

stable

Clone or download

Read-only

request #12250: Tracker webhook payload can be incorrect if email notifications are disabled

Download Browse

The payload sent by a tracker webhook can indicate an artifact has been created when in fact it's only an update. The issue arises when the email notifications are not enabled because the email notification task. The issue is caused by the fact the local changeset cache of an artifact is incomplete after an update. The email notification task, when executed, force fetch all the changesets to resolve inconsistencies in the cache. This contribution ensures the cache is clean before executing other post action tasks of an artifact. Change-Id: I6474a01eddb56100391a9f5710df67bc33977da4

+61 −2
Thomas Gerbet (tgerbet) 2018-09-10 13:32
Thomas Gerbet (tgerbet) 2018-09-10 13:38
51dbecdd045faf1433c2216c19fb631b97e3ca7c
54613dc8e2f557dc8127c747e381ad968242793e
git #tuleap/stable/51dbecdd045faf1433c2216c19fb631b97e3ca7c

Modified Files

Side by side diff
Inline diff
Name
M plugins/tracker/include/Tracker/Artifact/Changeset/PostCreation/ActionsRunner.php +1 −0 Go to diff View file
A plugins/tracker/include/Tracker/Artifact/Changeset/PostCreation/ClearArtifactChangesetCacheTask.php +32 −0 Go to diff View file
M plugins/tracker/include/Tracker/Artifact/Changeset/PostCreation/EmailNotificationTask.php +0 −2 Go to diff View file
M plugins/tracker/phpunit/Tracker/Artifact/Changeset/PostCreation/ActionsRunnerTest.php +28 −0 Go to diff View file