stable
Clone or download
Read-only
part of story #26802 have smart commit with Tuleap Git No functional change expected in GitLab artifact closure: - when there is a Done or a Closed value, the Artifact is closed with a comment. - when there is no Done or Closed value, or there is no Status field, a comment is added on the artifact to explain the problem. Notes: It replaces some mocks with a stub and avoids repeating the retrieval of the status field again in ArtifactClosingReferencesHandler Change-Id: I45bb490629d9e73eb735438d59d61db6bfaa9994
Modified Files
| Name | ||||
|---|---|---|---|---|
| M | plugins/gitlab/include/Repository/Webhook/PostPush/PostPushWebhookCloseArtifactHandler.php | +7 | −17 | Go to diff View file |
| M | plugins/gitlab/include/gitlabPlugin.php | +3 | −2 | Go to diff View file |
| M | plugins/gitlab/tests/unit/Repository/Webhook/PostPush/PostPushWebhookCloseArtifactHandlerTest.php | +11 | −23 | Go to diff View file |
| M | plugins/tracker/include/Tracker/Artifact/Closure/ArtifactCloser.php | +3 | −2 | Go to diff View file |
| A | plugins/tracker/include/Tracker/Semantic/Status/RetrieveStatusField.php | +28 | −0 | Go to diff View file |
| A | plugins/tracker/include/Tracker/Semantic/Status/StatusFieldRetriever.php | +35 | −0 | Go to diff View file |
| M | plugins/tracker/tests/unit/Artifact/Closure/ArtifactCloserTest.php | +12 | −27 | Go to diff View file |
| A | plugins/tracker/tests/unit/Stub/RetrieveStatusFieldStub.php | +45 | −0 | Go to diff View file |
| A | plugins/tracker/tests/unit/Tracker/Semantic/Status/StatusFieldRetrieverTest.php | +73 | −0 | Go to diff View file |