Public

Project privacy set to public. By default, its content is available to everyone (authenticated or not). Please note that more restrictive permissions might exist on some items.

stable

Clone or download

Read-only

Backend should enforce that the planning_tracker_id is linked to an existing and valid tracker

Download Browse

part of request #14986 report can throw a fatal error when db is inconsistent Actually when user browse a tracker report, we will build a list of criterias. Criterias might depends on external plugins (in our cas agiledashbaord). When AD configuration is broken (planning_tracker_id = 0), then we have a fatal error on report. This patch do NOT solve the fatal, for now I only introduce a check to be sure that the value given to planning_tracker_id correspond to an existing tracker. I will do a forgeupgrade to remove incorrect planning configuration in a dedicated changeset (and that will solves the fatal error) Change-Id: I081be908ca6be14f9dfc830b6db90c27f4eb2e37

+96 −8
Marie Ange Garnier (marieange) 2020-06-16 15:25
Marie Ange Garnier (marieange) 2020-06-17 13:46
528c363886f360f682fafd7e689b1ad006d0f653
d26bacb09d438b8c27b8544e89e1d50c0572a0b5
git #tuleap/stable/528c363886f360f682fafd7e689b1ad006d0f653

Modified Files

Side by side diff
Inline diff
Name
M plugins/agiledashboard/include/AgileDashboardRouter.class.php +9 −2 Go to diff View file
M plugins/agiledashboard/include/AgileDashboardRouterBuilder.php +2 −1 Go to diff View file
M plugins/agiledashboard/include/Planning/PlanningController.class.php +28 −1 Go to diff View file
M plugins/agiledashboard/include/Planning/PlanningParameters.class.php +3 −0 Go to diff View file
M plugins/agiledashboard/site-content/fr_FR/LC_MESSAGES/tuleap-agiledashboard.po +7 −2 Go to diff View file
M plugins/agiledashboard/tests/unit/AgileDashboard/Planning/PlanningControllerTest.php +45 −1 Go to diff View file
M plugins/agiledashboard/tests/unit/AgileDashboardRouterTest.php +2 −1 Go to diff View file