Public

Project privacy set to public. By default, its content is available to everyone (authenticated or not). Please note that more restrictive permissions might exist on some items.

stable

Clone or download

Read-only

refactor: Extract code placeholders insertion

Download Browse

part of request #29602 Migrate pullrequest file-diffs to TypeScript The insertion of code placeholder is now delegated to the SideBySideCodePlaceholderCreationManager (formerly SideBySideCodePlaceholderBuilder). Since this object was creating code placeholder widget creation parameters, it was the best candidate to also command the insertion of those placeholders when they are needed. [Bonus] I've fixed a bug that was occuring on the first line of the file, when this one was added. Now the opposite line should have a code placeholder above. How to test: -- No functional change in side-by-side diff mode Change-Id: Ibf6ece438efcea0e3047dac3f1c9cadb24cf40d9

+16 −20
Thomas Gorka (tgorka) 2022-11-25 17:12
Thomas Gorka (tgorka) 2022-11-25 17:12
577e68db8a6e0f6007dc56117f789138a3ee844f
935845d33b863c1a85f5ead607d85e72ffa3da71
git #tuleap/stable/577e68db8a6e0f6007dc56117f789138a3ee844f

Modified Files

Side by side diff
Inline diff
Name
R plugins/pullrequest/scripts/pullrequests-app/src/app/file-diff/diff-modes/side-by-side-code-placeholder-builder.test.ts Go to diff View file
R plugins/pullrequest/scripts/pullrequests-app/src/app/file-diff/diff-modes/side-by-side-code-placeholder-builder.ts Go to diff View file
M plugins/pullrequest/scripts/pullrequests-app/src/app/file-diff/diff-modes/side-by-side-diff-component.js +6 −16 Go to diff View file
M plugins/pullrequest/scripts/pullrequests-app/tests/stubs/GroupSideBySideLinesStub.ts +10 −4 Go to diff View file