stable
Clone or download
How to test: - When you create a new artifact with the modal (for example in Kanban) and there is an error, the error message will appear at the top of the modal in a fixed section (you no longer need to scroll to see it). - When you click the submit button, it will be disabled while the REST calls (file upload, artifact creation) are in-flight. - When there is an error during file upload, it will also be shown at the top of the modal in the fixed section. - No functional change expected for artifact edition. Error message for edition will be handled in a separate commit. part of story #28823 [modal] create artifact Also part of request #29640 Artifact modale should better highlight when there are errors Also part of request #10555 Artifact modal does not clearly says that there are errors Change-Id: I36595420714a4155ad6160961c5e7a018af46dbd
Modified Files
| Name | ||||
|---|---|---|---|---|
| M | plugins/tracker/scripts/lib/artifact-modal/po/fr_FR.po | +8 | −2 | Go to diff View file |
| M | plugins/tracker/scripts/lib/artifact-modal/po/pt_BR.po | +6 | −0 | Go to diff View file |
| M | plugins/tracker/scripts/lib/artifact-modal/src/adapters/REST/TuleapAPIClient.test.ts | +58 | −17 | Go to diff View file |
| M | plugins/tracker/scripts/lib/artifact-modal/src/adapters/REST/TuleapAPIClient.ts | +17 | −1 | Go to diff View file |
| M | plugins/tracker/scripts/lib/artifact-modal/src/adapters/UI/feedback/ErrorMessageFormatter.test.ts | +16 | −15 | Go to diff View file |
| M | plugins/tracker/scripts/lib/artifact-modal/src/adapters/UI/feedback/ErrorMessageFormatter.ts | +15 | −0 | Go to diff View file |
| A | plugins/tracker/scripts/lib/artifact-modal/src/domain/ArtifactCreated.ts | +22 | −0 | Go to diff View file |
| A | plugins/tracker/scripts/lib/artifact-modal/src/domain/TrackerIdentifier.ts | +22 | −0 | Go to diff View file |
| A | plugins/tracker/scripts/lib/artifact-modal/src/domain/submit/ArtifactCreationFault.ts | +25 | −0 | Go to diff View file |
| A | plugins/tracker/scripts/lib/artifact-modal/src/domain/submit/ChangesetValues.ts | +27 | −0 | Go to diff View file |
| A | plugins/tracker/scripts/lib/artifact-modal/src/domain/submit/CreateArtifact.ts | +32 | −0 | Go to diff View file |
| M | plugins/tracker/scripts/lib/artifact-modal/src/gettext-catalog.ts | +3 | −0 | Go to diff View file |
| M | plugins/tracker/scripts/lib/artifact-modal/src/rest/rest-service.test.ts | +0 | −34 | Go to diff View file |
| M | plugins/tracker/scripts/lib/artifact-modal/src/rest/rest-service.ts | +8 | −38 | Go to diff View file |
| M | plugins/tracker/scripts/lib/artifact-modal/src/tuleap-artifact-modal-controller.js | +48 | −55 | Go to diff View file |
| M | plugins/tracker/scripts/lib/artifact-modal/src/tuleap-artifact-modal-controller.test.js | +42 | −47 | Go to diff View file |
| A | plugins/tracker/scripts/lib/artifact-modal/tests/stubs/TrackerIdentifierStub.ts | +24 | −0 | Go to diff View file |
| M | plugins/tracker/scripts/lib/rest-api-types/src/artifacts_write.ts | +13 | −4 | Go to diff View file |