stable

Clone or download

Read-only

Refactoring: do not pass unneeded parameters to visitors

This is a part of story #8858 query tracker with expressions No functional changes. PHPΒ does not let us to have both proper Parameters and Visitor inheritance. Therefore we remove the contract definition in the Visitor so that we can vary the parameters given to each visitor. That way we do not need to pass not needed parameters to everyone. However this means that every time we create a visitor, we will need to guess the needed functions to parse the tree, but we think that it is the best wow as of today given the PHP limitations. Change-Id: I46475a95fedbaa88a827df186fe55f26a1462ad6

Modified Files

Name
M plugins/tracker/include/Tracker/Report/Query/Advanced/Grammar/AndExpression.php +4 βˆ’4 Go to diff View file
M plugins/tracker/include/Tracker/Report/Query/Advanced/Grammar/AndOperand.php +4 βˆ’4 Go to diff View file
M plugins/tracker/include/Tracker/Report/Query/Advanced/Grammar/Comparison.php +3 βˆ’3 Go to diff View file
A plugins/tracker/include/Tracker/Report/Query/Advanced/Grammar/DepthValidatorParameters.php +24 βˆ’0 Go to diff View file
R plugins/tracker/include/Tracker/Report/Query/Advanced/Grammar/DepthValidator.php Go to diff View file
A plugins/tracker/include/Tracker/Report/Query/Advanced/Grammar/InvalidFieldsCollectorParameters.php +58 βˆ’0 Go to diff View file
R plugins/tracker/include/Tracker/Report/Query/Advanced/Grammar/Collector.php Go to diff View file
M plugins/tracker/include/Tracker/Report/Query/Advanced/Grammar/OrExpression.php +4 βˆ’4 Go to diff View file
M plugins/tracker/include/Tracker/Report/Query/Advanced/Grammar/OrOperand.php +4 βˆ’4 Go to diff View file
A plugins/tracker/include/Tracker/Report/Query/Advanced/Grammar/QueryBuilderParameters.php +43 βˆ’0 Go to diff View file
R plugins/tracker/include/Tracker/Report/Query/Advanced/Grammar/QueryBuilder.php Go to diff View file
A plugins/tracker/include/Tracker/Report/Query/Advanced/Grammar/Visitable.php +25 βˆ’0 Go to diff View file
M plugins/tracker/include/Tracker/Report/Query/Advanced/Grammar/Visitor.php +1 βˆ’13 Go to diff View file
A plugins/tracker/include/Tracker/Report/Query/Advanced/Grammar/VisitorParameters.php +24 βˆ’0 Go to diff View file
M plugins/tracker/include/Tracker/Report/Tracker_Report.class.php +17 βˆ’17 Go to diff View file
M plugins/tracker/include/autoload.php +10 βˆ’5 Go to diff View file
M plugins/tracker/tests/Tracker/Report/Query/Advanced/Grammar/DepthValidatorTest.php +3 βˆ’3 Go to diff View file
R plugins/tracker/tests/Tracker/Report/Query/Advanced/Grammar/CollectorTest.php Go to diff View file
M plugins/tracker/tests/Tracker/Report/Query/Advanced/Grammar/QueryBuilderTest.php +28 βˆ’27 Go to diff View file