stable
Clone or download
Read-only
No functional change expected when creating replies to inline comments in overview, unidiff or side-by-side diff views. Since those properties are never useful to the template part, we can move them to the controller. It avoids some back-and-forth, as previously we had to init the custom element just so it could pass them back to the controller. part of request #29602 Migrate pullrequest file-diffs to TypeScript Change-Id: I1ded18a5e9ff1691b2f11cd83627ac650f92e4c2
Modified Files
| Name | ||||
|---|---|---|---|---|
| M | plugins/pullrequest/scripts/pullrequests-app/src/app/comments/PullRequestComment.ts | +1 | −7 | Go to diff View file |
| M | plugins/pullrequest/scripts/pullrequests-app/src/app/comments/PullRequestCommentController.test.ts | +32 | −43 | Go to diff View file |
| M | plugins/pullrequest/scripts/pullrequests-app/src/app/comments/PullRequestCommentController.ts | +7 | −3 | Go to diff View file |
| M | plugins/pullrequest/scripts/pullrequests-app/src/app/file-diff/diff-modes/side-by-side-code-mirror-widget-creator.test.ts | +2 | −14 | Go to diff View file |
| M | plugins/pullrequest/scripts/pullrequests-app/src/app/file-diff/diff-modes/side-by-side-code-mirror-widget-creator.ts | +1 | −7 | Go to diff View file |
| M | plugins/pullrequest/scripts/pullrequests-app/src/app/file-diff/diff-modes/side-by-side-diff-component.js | +7 | −7 | Go to diff View file |
| M | plugins/pullrequest/scripts/pullrequests-app/src/app/file-diff/diff-modes/unidiff-component.js | +7 | −7 | Go to diff View file |
| M | plugins/pullrequest/scripts/pullrequests-app/src/app/overview/timeline/timeline-controller.js | +3 | −1 | Go to diff View file |