stable

Clone or download

Read-only

Refactoring: Rename InvalidFields to InvalidSearchables

Part of story #9882: TQL in follow-up comments When we parse the query, we collect not only invalid fiels, but also invalid metadata. Therefore rename fields to metadata during this collection. For the end users, we still display "The field xxx does not exist" because its the closest term available to its understanding (we should not talk about "searchable" or "metadata" in the ui). + Remove unneeded dependency on field factory + Enforce InvalidFields\* usage in InvalidSearchableCollectorVisitor to better highlights that the ComparisonVisitor only target fields. No functional changes: If we use @comment = 'toto', then an error is raised saying that @comment is not supported. If we use @summary = 'toto', then an error is raised saying that @summary is unknown. If we use summary = 'toto', then the query is performed successfully. Change-Id: I261a7a97998c9e8a8b9fa3913ded88321ebcaa12

Modified Files

Name
M plugins/tracker/include/REST/v1/TrackersResource.class.php +4 −4 Go to diff View file
R plugins/tracker/include/Tracker/Report/Query/Advanced/InvalidFieldsCollection.php Go to diff View file
R plugins/tracker/include/Tracker/Report/Query/Advanced/InvalidFieldsCollectorParameters.php Go to diff View file
R plugins/tracker/include/Tracker/Report/Query/Advanced/InvalidFieldsCollectorVisitor.php Go to diff View file
R plugins/tracker/include/Tracker/Report/Query/Advanced/InvalidSearchableCollectorParameters.php Go to diff View file
R plugins/tracker/include/Tracker/Report/Query/Advanced/InvalidSearchableCollectorVisitor.php Go to diff View file
R plugins/tracker/include/Tracker/Report/Query/Advanced/FieldsAreInvalidException.php Go to diff View file
R plugins/tracker/include/Tracker/Report/Query/Advanced/FieldsDoNotExistException.php Go to diff View file
M plugins/tracker/include/Tracker/Report/Tracker_Report.class.php +28 −29 Go to diff View file
M plugins/tracker/include/autoload.php +9 −9 Go to diff View file
R plugins/tracker/tests/Tracker/Report/Query/Advanced/InvalidFieldsCollectorVisitorTest.php Go to diff View file