stable
Clone or download
Read-only
request #8151: Request-URI Too Large in GET /users_memberships
Passing long list of users in GET request is not possible when there is a huge number of users to fetch. Since the feature is used as of today only for gitolite, we use now a query field to select only users with ssh keys. This solution should be future proof since we can later on add other options like 'all_users', 'self', … As retrieving self membership information since not be used, we drop it in order to remove dead code. Change-Id: I001b48584acf459f9dadbd4a096b8c2427d79b54
Modified Files
| Name | ||||
|---|---|---|---|---|
| M | src/common/dao/UserDao.class.php | +72 | −58 | Go to diff View file |
| M | src/common/user/PaginatedUserCollection.class.php | +5 | −1 | Go to diff View file |
| M | src/common/user/REST/v1/UserMembershipResource.php | +38 | −40 | Go to diff View file |
| M | src/common/user/REST/v1/UserResource.php | +0 | −1 | Go to diff View file |
| M | src/common/user/UserManager.class.php | +60 | −48 | Go to diff View file |
| M | tests/lib/rest/TestDataBuilder.php | +1 | −0 | Go to diff View file |
| M | tests/rest/UserMembershipTest.php | +3 | −33 | Go to diff View file |