Public

Project privacy set to public. By default, its content is available to everyone (authenticated or not). Please note that more restrictive permissions might exist on some items.

stable

Clone or download

Read-only

refactor: use an interface for the Bad semantic comment

Download Browse

part of story #26802 have smart commit with Tuleap Git No functional change expected in GitLab artifact closure: when there is no Done or Closed value, or there is no Status field, a comment is added on the artifact to explain the problem. Notes: The comment metadata are not very important for the caller, so they are hidden in PostPushCommitArtifactUpdater to make it easier to call. The caller provides two comment bodies that are always in CommonMark format, and ArtifactUpdater provides the metadata. Change-Id: I8e80d481d8e1980536e573149d635c74b01f022a

+174 −87
Joris MASSON (jmasson) 2022-07-07 10:16
Joris MASSON (jmasson) 2022-07-07 10:23
656b0c43a887607fe51b1849fbce4f820f512ee2
1677a98315d3f5464d1b014a2b0c2aa6b878f631
git #tuleap/stable/656b0c43a887607fe51b1849fbce4f820f512ee2

Modified Files

Side by side diff
Inline diff
Name
A plugins/gitlab/include/Repository/Webhook/PostPush/BadSemanticCommentInCommonMarkFormat.php +35 −0 Go to diff View file
A plugins/gitlab/include/Repository/Webhook/PostPush/PostPushBadSemanticComment.php +48 −0 Go to diff View file
M plugins/gitlab/include/Repository/Webhook/PostPush/PostPushCommitArtifactUpdater.php +23 −5 Go to diff View file
M plugins/gitlab/include/Repository/Webhook/PostPush/PostPushWebhookCloseArtifactHandler.php +7 −15 Go to diff View file
A plugins/gitlab/tests/unit/Repository/Webhook/PostPush/PostPushBadSemanticCommentTest.php +55 −0 Go to diff View file
M plugins/gitlab/tests/unit/Repository/Webhook/PostPush/PostPushCommitArtifactUpdaterTest.php +6 −4 Go to diff View file
D plugins/tracker/tests/unit/Builders/NewCommentTestBuilder.php +0 −63 Go to diff View file