Public

Project privacy set to public. By default, its content is available to everyone (authenticated or not). Please note that more restrictive permissions might exist on some items.

stable

Clone or download

Read-only

feat: show Error when autocomplete error code is not 403 or 404

Download Browse

part of story #24969 [modal] add and remove links (replace current artifact link) How to test: - Type something in the input that does not match any artifact id, like "-1" - You should keep seeing "No matching artifact" - Type an artifact id in the input - If there is an error that does not have 404 or 403 http code (for example throw a RestException with code 500 in ArtifactsResource), then it will show up at the top of the modal in the feedback section. - If the error is removed and you type again in the field, the error message should be cleared. Note: the rules for matching an artifact id are now stricter and should no longer allow "-1" or "1e5". Unless the number is positive and strictly an integer, it will not match. Change-Id: Ia74e9519f4656a31708f8ad95936f62c6a39aa2b

+316 −170
Joris MASSON (jmasson) 2022-05-03 10:53
Joris MASSON (jmasson) 2022-05-03 14:46
69bbd33f756251bdf66893c5a2d48e40c240b8dd
3f53455d5da7602f84ae447ce31920c3471e3f35
git #tuleap/stable/69bbd33f756251bdf66893c5a2d48e40c240b8dd

Modified Files

Side by side diff
Inline diff
Name
M plugins/tracker/scripts/lib/artifact-modal/po/fr_FR.po +4 −1 Go to diff View file
M plugins/tracker/scripts/lib/artifact-modal/po/pt_BR.po +3 −0 Go to diff View file
M plugins/tracker/scripts/lib/artifact-modal/src/adapters/UI/feedback/FaultFeedbackController.test.ts +13 −0 Go to diff View file
M plugins/tracker/scripts/lib/artifact-modal/src/adapters/UI/feedback/FaultFeedbackController.ts +9 −3 Go to diff View file
M plugins/tracker/scripts/lib/artifact-modal/src/adapters/UI/feedback/FaultFeedbackPresenter.test.ts +8 −0 Go to diff View file
M plugins/tracker/scripts/lib/artifact-modal/src/adapters/UI/feedback/FaultFeedbackPresenter.ts +6 −0 Go to diff View file
M plugins/tracker/scripts/lib/artifact-modal/src/adapters/UI/fields/link-field-v2/AddLinkButtonTemplate.test.ts +5 −1 Go to diff View file
M plugins/tracker/scripts/lib/artifact-modal/src/adapters/UI/fields/link-field-v2/ArtifactLinkSelectorAutoCompleter.test.ts +57 −6 Go to diff View file
M plugins/tracker/scripts/lib/artifact-modal/src/adapters/UI/fields/link-field-v2/ArtifactLinkSelectorAutoCompleter.ts +21 −9 Go to diff View file
M plugins/tracker/scripts/lib/artifact-modal/src/adapters/UI/fields/link-field-v2/LinkFieldController.test.ts +70 −138 Go to diff View file
M plugins/tracker/scripts/lib/artifact-modal/src/adapters/UI/fields/link-field-v2/LinkableNumberProxy.test.ts +16 −6 Go to diff View file
M plugins/tracker/scripts/lib/artifact-modal/src/adapters/UI/fields/link-field-v2/LinkableNumberProxy.ts +7 −3 Go to diff View file
M plugins/tracker/scripts/lib/artifact-modal/src/adapters/UI/fields/link-field-v2/LinkedArtifactTemplate.test.ts +5 −1 Go to diff View file
A plugins/tracker/scripts/lib/artifact-modal/src/domain/ClearFaultNotification.ts +22 −0 Go to diff View file
A plugins/tracker/scripts/lib/artifact-modal/src/domain/fields/link-field-v2/MatchingArtifactRetrievalFault.ts +25 −0 Go to diff View file
M plugins/tracker/scripts/lib/artifact-modal/src/gettext-catalog.ts +2 −0 Go to diff View file
M plugins/tracker/scripts/lib/artifact-modal/src/tuleap-artifact-modal-controller.js +6 −1 Go to diff View file
A plugins/tracker/scripts/lib/artifact-modal/tests/stubs/ClearFaultNotificationStub.ts +36 −0 Go to diff View file
M plugins/tracker/scripts/lib/artifact-modal/tests/stubs/NotifyFaultStub.ts +1 −1 Go to diff View file