Public

Project privacy set to public. By default, its content is available to everyone (authenticated or not). Please note that more restrictive permissions might exist on some items.

stable

Clone or download

Read-only

refactor: Introduce FileLineHandleStubs in unit tests

Download Browse

part of request #29602 Migrate pullrequest file-diffs to TypeScript This refactoring simplifies the writing of unit tests where FileLineHandles are manipulated (e.g almost everywhere) Now we can build stubbed handles containing FileDiffWidgets of any kind, or not with their own heights. -- No functional changes expected -- CI should be happy Change-Id: I273522c5e9eb5c53a5496f6c63730c4f22af21e5

+197 −190
Thomas Gorka (tgorka) 2022-11-16 12:47
Thomas Gorka (tgorka) 2022-11-16 16:20
6b42710942cd01354095d020a2c01a9d4903430e
2597a05455c3c2d830440515234694482902b406
git #tuleap/stable/6b42710942cd01354095d020a2c01a9d4903430e

Modified Files

Side by side diff
Inline diff
Name
M plugins/pullrequest/scripts/pullrequests-app/src/app/file-diff/diff-modes/side-by-side-code-placeholder-builder.test.js +13 −12 Go to diff View file
M plugins/pullrequest/scripts/pullrequests-app/src/app/file-diff/diff-modes/side-by-side-comment-placeholder-builder.test.js +37 −38 Go to diff View file
M plugins/pullrequest/scripts/pullrequests-app/src/app/file-diff/diff-modes/side-by-side-comment-placeholder-widget-finder.test.ts +8 −18 Go to diff View file
M plugins/pullrequest/scripts/pullrequests-app/src/app/file-diff/diff-modes/side-by-side-line-height-equalizer.test.js +39 −99 Go to diff View file
M plugins/pullrequest/scripts/pullrequests-app/src/app/file-diff/diff-modes/side-by-side-line-widgets-helper.test.ts +17 −11 Go to diff View file
M plugins/pullrequest/scripts/pullrequests-app/src/app/file-diff/diff-modes/side-by-side-lines-state.test.js +9 −8 Go to diff View file
M plugins/pullrequest/scripts/pullrequests-app/src/app/file-diff/diff-modes/side-by-side-placeholder-positioner.test.js +3 −2 Go to diff View file
M plugins/pullrequest/scripts/pullrequests-app/src/app/file-diff/diff-modes/types-codemirror-overriden.ts +11 −2 Go to diff View file
A plugins/pullrequest/scripts/pullrequests-app/tests/stubs/FileLineHandleStub.ts +60 −0 Go to diff View file