Public

Project privacy set to public. By default, its content is available to everyone (authenticated or not). Please note that more restrictive permissions might exist on some items.

stable

Clone or download

Read-only

GraphOnTrackersV5_InSessionChartSorter works as expected on PHP 8.0

Download Browse

The element was not sorted correctly due to the saner string to number comparison introduced in PHP 8.0 [0]. The specific case of wanting a chart at the position 0 is now explicitly managed. The tests should now pass with PHP 8.0: make tests-unit-php PHP_VERSION=80 FILES=plugins/graphontrackersv5/tests/unit/GraphOnTrackersV5_InSessionChartSorterTest.php Part of request #17931: Unit tests should pass with PHP 8.0 [0] https://www.php.net/releases/8.0/en.php#saner-string-to-number-comparisons Change-Id: Ibaee7a6f291484d97077b92dec3fa6b1e8020b1f

+4 −1
Thomas Gerbet (tgerbet) 2020-12-22 12:03
Thomas Gerbet (tgerbet) 2020-12-22 12:09
6e0e4f294deb3160719e18cdc924691a6c0dd5cc
4c5db56a34829ba750d02088d4eb487132e3766d
git #tuleap/stable/6e0e4f294deb3160719e18cdc924691a6c0dd5cc

Modified Files

Side by side diff
Inline diff
Name
M plugins/graphontrackersv5/include/data-access/GraphOnTrackersV5_InSessionChartSorter.class.php +4 −1 Go to diff View file