Public

Project privacy set to public. By default, its content is available to everyone (authenticated or not). Please note that more restrictive permissions might exist on some items.

stable

Clone or download

Read-only

Refactoring: Deduplicate RemainingEffortValueRetriever

Download Browse

No need to duplicate the logic to retrieve the remaining effort for an artifact. Furthermore old RemainingEffortValueRetriever already has decent test coverage. Part of story #13865: Display effort, avatar and progress on cards Change-Id: I5fa9275f2123b4ce1606cfcc4cf1f8b4fc165f86

+42 −103
Nicolas Terray (nterray) 2019-10-02 09:49
Nicolas Terray (nterray) 2019-10-02 11:48
71b0db5752aca693f2e2c364b392fa7edc732349
cd2fdf8659064fc69d34a787ec54779daf6565ae
git #tuleap/stable/71b0db5752aca693f2e2c364b392fa7edc732349

Modified Files

Side by side diff
Inline diff
Name
M plugins/agiledashboard/include/AgileDashboard/Milestone/Backlog/BacklogItemCollectionFactory.class.php +5 −5 Go to diff View file
M plugins/agiledashboard/include/AgileDashboard/Milestone/Backlog/IBacklogItem.class.php +5 −0 Go to diff View file
M plugins/agiledashboard/include/AgileDashboard/REST/v1/BacklogItemResource.php +3 −3 Go to diff View file
M plugins/agiledashboard/include/AgileDashboard/REST/v1/MilestoneResource.class.php +1 −1 Go to diff View file
M plugins/agiledashboard/include/AgileDashboard/REST/v1/ProjectBacklogResource.class.php +1 −1 Go to diff View file
M plugins/agiledashboard/include/AgileDashboard/REST/v2/ProjectBacklogResource.class.php +12 −12 Go to diff View file
R plugins/agiledashboard/include/AgileDashboard/BacklogItem/RemainingEffortValueRetriever.php Go to diff View file
M plugins/agiledashboard/include/AgileDashboardRouterBuilder.php +2 −3 Go to diff View file
M plugins/agiledashboard/include/agiledashboardPlugin.php +1 −1 Go to diff View file
R plugins/agiledashboard/phpunit/AgileDashboard/BacklogItem/RemainingEffortValueRetrieverTest.php Go to diff View file
M plugins/agiledashboard/tests/include/AgileDashboard/Milestone/Backlog/AgileDashboard_Milestone_Backlog_BacklogItemCollectionFactoryTest.php +2 −2 Go to diff View file
M plugins/cardwall/include/Pane.class.php +1 −1 Go to diff View file
D plugins/taskboard/include/Card/CardRemainingEffortRetriever.php +0 −65 Go to diff View file
M plugins/taskboard/include/REST/v1/CardRepresentationBuilder.php +9 −9 Go to diff View file