Public

Project privacy set to public. By default, its content is available to everyone (authenticated or not). Please note that more restrictive permissions might exist on some items.

stable

Clone or download

Read-only

Hightlight potentially dangerous bidirectional characters in PR diff

Download Browse

We extend the default CodeMirror regex for the special chars to make those characters visible. It is not really a great way to make them visible but it is still better than nothing and if it is good enough to be a CodeMirror default it is likely good enough for our situation. Part of request #23496: Add warnings when displaying code with bidirectional Unicode text in Git/PR web UI Change-Id: I5c93b9e1734f96f543a5bded6e4a19fbf5bfac9e

+74 −14
Thomas Gerbet (tgerbet) 2021-11-08 17:06
Thomas Gerbet (tgerbet) 2021-11-08 17:06
7302eb2dc5daa3250fe5bc906e71905d46d38f81
24ce2b4c2e0cb0d24d1604fe8e17aafc3c6ba5dd
git #tuleap/stable/7302eb2dc5daa3250fe5bc906e71905d46d38f81

Modified Files

Side by side diff
Inline diff
Name
M plugins/pullrequest/package.json +1 −0 Go to diff View file
M plugins/pullrequest/pnpm-lock.yaml +18 −0 Go to diff View file
M plugins/pullrequest/scripts/src/app/file-diff/diff-bidirectional-unicode-text.test.ts +16 −1 Go to diff View file
M plugins/pullrequest/scripts/src/app/file-diff/diff-bidirectional-unicode-text.ts +22 −0 Go to diff View file
M plugins/pullrequest/scripts/src/app/file-diff/diff-modes/side-by-side-diff-component.js +9 −7 Go to diff View file
M plugins/pullrequest/scripts/src/app/file-diff/diff-modes/unidiff-component.js +8 −6 Go to diff View file