Public

Project privacy set to public. By default, its content is available to everyone (authenticated or not). Please note that more restrictive permissions might exist on some items.

stable

Clone or download

Read-only

Add left or right position to inline_comment representation

Download Browse

Part of story #11667 Finish pull request side-by-side diff How to test: - Make post-checkout --> column is_on_left_side has been added to plugin_pullrequest_inline_comments - Go to the api explorer and query get /pull_requests/{id}/file_diff - Take a look at inline_comments in the json --> You should see an attribute is_on_left_side in each inline comment representation. --> Default value is 'right' --> No functional change expected in the pullrequest app Change-Id: I996711a4a7a0ed899a5bb4bd99efaf34da19be45

+67 −14
Thomas Gorka (tgorka) 2018-09-17 12:17
Thomas Gorka (tgorka) 2018-09-21 13:07
7950ee848f93f3225537f5b681ba5f9f0abea580
cee59004dea6f55adaa77c2fde54930703e9b2f9
git #tuleap/stable/7950ee848f93f3225537f5b681ba5f9f0abea580

Modified Files

Side by side diff
Inline diff
Name
M plugins/pullrequest/db/install.sql +9 −8 Go to diff View file
A plugins/pullrequest/db/mysql/updates/2018/201809171115_add_inline_comment_position_column.php +45 −0 Go to diff View file
M plugins/pullrequest/include/PullRequest/REST/v1/PullRequestInlineCommentRepresentation.php +8 −2 Go to diff View file
M plugins/pullrequest/include/PullRequest/REST/v1/PullRequestInlineCommentRepresentationBuilder.php +3 −3 Go to diff View file
M plugins/pullrequest/include/PullRequest/REST/v1/PullRequestsResource.php +2 −1 Go to diff View file