Public

Project privacy set to public. By default, its content is available to everyone (authenticated or not). Please note that more restrictive permissions might exist on some items.

stable

Clone or download

Read-only

request #14968 TLP modal should not crash when hidden before being shown

Download Browse

How to test: - in src/ run "npm run build" - Browse to a TestManagement campaign. Click on the "Edit campaign" button. Click on "Add a test" button. A "Create artifact" modal should open. Click on the "Cancel" button. - You should not have a DOMException in the console: "Uncaught DOMException: Node.removeChild: The node to be removed is not a child of this node" - The modal and its backdrop element are removed. - Thanks to Babel transpilation, Internet Explorer 11 does not crash (it does not support ChildNode.remove() DOM API). - "make tests_cypress" should succeed on TestManagement e2e tests Change-Id: Iadd191577172689017552690887722fdac766809

+16 −2
Joris MASSON (jmasson) 2020-06-10 10:31
Joris MASSON (jmasson) 2020-06-10 10:32
7d7ce2c4a0adf44e8ba1bd15244af7672cd54fb2
f4264adf27d4896a1eef239d3408c088ba2bfdde
git #tuleap/stable/7d7ce2c4a0adf44e8ba1bd15244af7672cd54fb2

Modified Files

Side by side diff
Inline diff
Name
M src/themes/tlp/src/js/modal.js +4 −1 Go to diff View file
M src/themes/tlp/src/js/modal.test.ts +12 −1 Go to diff View file