stable
Clone or download
Read-only
Currently there are too much different terms used to refer to a gitlab repository: * id * gitlab_id * gitlab_internal_id * internal_gitlab_id * gitlab_repository_id New comers don't necessarily know what those variables are refering to. In order to remove the ambiguity, I propose to use: * id/repository_id: The id of the integration * gitlab_repository_id: The id used by GitLab for the project/repository No functional changes. Part of story #17182: reference tuleap artifacts in gitlab merge requests Change-Id: I466f04ee76157dcffddffb324f28f4a0f57d6c54
Modified Files
| Name | ||||
|---|---|---|---|---|
| M | plugins/git/scripts/repositories/src/api/rest-querier.js | +2 | −2 | Go to diff View file |
| M | plugins/git/scripts/repositories/src/api/rest-querier.test.js | +3 | −3 | Go to diff View file |
| M | plugins/git/scripts/repositories/src/components/GitRepository.test.js | +4 | −4 | Go to diff View file |
| M | plugins/git/scripts/repositories/src/components/GitlabModal/CreateGitlabLinkModal/ListRepositoriesModal.test.js | +5 | −2 | Go to diff View file |
| M | plugins/git/scripts/repositories/src/components/GitlabModal/CreateGitlabLinkModal/ListRepositoriesModal.vue | +2 | −2 | Go to diff View file |
| M | plugins/git/scripts/repositories/src/gitlab/gitlab-checker.test.ts | +3 | −3 | Go to diff View file |
| M | plugins/git/scripts/repositories/src/gitlab/gitlab-checker.ts | +1 | −1 | Go to diff View file |
| M | plugins/git/scripts/repositories/src/gitlab/gitlab-repository-formatter.test.ts | +4 | −4 | Go to diff View file |
| M | plugins/git/scripts/repositories/src/gitlab/gitlab-repository-formatter.ts | +1 | −1 | Go to diff View file |
| M | plugins/git/scripts/repositories/src/store/getters.test.js | +1 | −1 | Go to diff View file |
| M | plugins/git/scripts/repositories/src/store/mutations.test.js | +5 | −5 | Go to diff View file |
| M | plugins/git/scripts/repositories/src/type.ts | +2 | −2 | Go to diff View file |
| M | plugins/gitlab/db/install.sql | +5 | −5 | Go to diff View file |
| A | plugins/gitlab/db/mysql/2021/202101151549_rename_gitlab_id_column.php | +78 | −0 | Go to diff View file |
| M | plugins/gitlab/include/API/GitlabProjectBuilder.php | +2 | −2 | Go to diff View file |
| M | plugins/gitlab/include/REST/v1/BotApiTokenUpdater.php | +3 | −3 | Go to diff View file |
| M | plugins/gitlab/include/REST/v1/ConcealedBotApiTokenPatchRepresentation.php | +3 | −3 | Go to diff View file |
| M | plugins/gitlab/include/REST/v1/GitlabProjectResource.php | +7 | −2 | Go to diff View file |
| M | plugins/gitlab/include/REST/v1/GitlabRepositoryBotApiTokenPatchRepresentation.php | +1 | −1 | Go to diff View file |
| M | plugins/gitlab/include/REST/v1/GitlabRepositoryPOSTRepresentation.php | +1 | −1 | Go to diff View file |
| M | plugins/gitlab/include/REST/v1/GitlabRepositoryRepresentation.php | +9 | −22 | Go to diff View file |
| M | plugins/gitlab/include/REST/v1/GitlabRepositoryResource.php | +25 | −18 | Go to diff View file |
| M | plugins/gitlab/include/Reference/Commit/GitlabCommit.php | +6 | −17 | Go to diff View file |
| M | plugins/gitlab/include/Reference/Commit/GitlabCommitFactory.php | +0 | −1 | Go to diff View file |
| M | plugins/gitlab/include/Repository/GitlabRepository.php | +10 | −10 | Go to diff View file |
| M | plugins/gitlab/include/Repository/GitlabRepositoryCreator.php | +45 | −50 | Go to diff View file |
| M | plugins/gitlab/include/Repository/GitlabRepositoryDao.php | +19 | −16 | Go to diff View file |
| M | plugins/gitlab/include/Repository/GitlabRepositoryDeletor.php | +10 | −10 | Go to diff View file |
| M | plugins/gitlab/include/Repository/GitlabRepositoryFactory.php | +9 | −9 | Go to diff View file |
| M | plugins/gitlab/include/Repository/Token/GitlabBotApiTokenDao.php | +8 | −8 | Go to diff View file |
| M | plugins/gitlab/include/Repository/Webhook/PostPush/Commits/CommitTuleapReferenceDAO.php | +6 | −7 | Go to diff View file |
| M | plugins/gitlab/include/Repository/Webhook/PostPush/PostPushCommitBotCommenter.php | +1 | −1 | Go to diff View file |
| M | plugins/gitlab/include/Repository/Webhook/Secret/SecretGenerator.php | +2 | −5 | Go to diff View file |
| M | plugins/gitlab/include/Repository/Webhook/Secret/SecretNotDefinedException.php | +2 | −2 | Go to diff View file |
| M | plugins/gitlab/include/Repository/Webhook/WebhookCreator.php | +6 | −7 | Go to diff View file |
| M | plugins/gitlab/include/Repository/Webhook/WebhookRepositoryRetriever.php | +1 | −1 | Go to diff View file |
| M | plugins/gitlab/tests/rest/DatabaseInitialization.php | +1 | −1 | Go to diff View file |
| M | plugins/gitlab/tests/rest/Gitlab/ProjectTest.php | +2 | −2 | Go to diff View file |
| M | plugins/gitlab/tests/unit/REST/v1/BotApiTokenUpdaterTest.php | +11 | −11 | Go to diff View file |
| M | plugins/gitlab/tests/unit/Reference/Commit/GitlabCommitCrossReferenceEnhancerTest.php | +0 | −1 | Go to diff View file |
| M | plugins/gitlab/tests/unit/Reference/Commit/GitlabCommitFactoryTest.php | +0 | −1 | Go to diff View file |
| M | plugins/gitlab/tests/unit/Reference/GitlabCrossReferenceOrganizerTest.php | +0 | −2 | Go to diff View file |
| M | plugins/gitlab/tests/unit/Repository/GitlabRepositoryCreatorTest.php | +5 | −5 | Go to diff View file |
| M | plugins/gitlab/tests/unit/Repository/GitlabRepositoryFactoryTest.php | +2 | −2 | Go to diff View file |
| M | plugins/gitlab/tests/unit/Repository/Webhook/PostPush/PostPushCommitBotCommenterTest.php | +2 | −2 | Go to diff View file |
| M | plugins/gitlab/tests/unit/Repository/Webhook/WebhookRepositoryRetrieverTest.php | +2 | −2 | Go to diff View file |