stable
Clone or download
Read-only
No functional change. Note: the parameter `is_registration_confirmation` is removed because since git #tuleap/stable/c2bfda84e53fc5220dd4789d8276f3485b064b6d it is always false. Bonus: this also encapsulates `$is_admin` and `$is_password_needed` in a dedicated object to avoid Primitive Obsession. This is is the last piece of register.php puzzle refactoring for the current request. The result is considered good enough for future developments about user registration. Closes request #29605: Convert account registration pages to BurningParrot Change-Id: I8ffd690fa61154aa6e6b1cbdefc8b042429a47a5
Modified Files
| Name | ||||
|---|---|---|---|---|
| M | plugins/openidconnectclient/include/openidconnectclientPlugin.php | +6 | −14 | Go to diff View file |
| M | src/common/Request/RouteCollector.php | +1 | −5 | Go to diff View file |
| A | src/common/User/Account/Register/BeforeUserRegistrationEvent.php | +49 | −0 | Go to diff View file |
| M | src/common/User/Account/Register/DisplayAdminRegisterFormController.php | +1 | −4 | Go to diff View file |
| M | src/common/User/Account/Register/DisplayRegisterFormController.php | +4 | −12 | Go to diff View file |
| M | src/common/User/Account/Register/IDisplayRegisterForm.php | +1 | −1 | Go to diff View file |
| M | src/common/User/Account/Register/IProcessRegisterForm.php | +1 | −1 | Go to diff View file |
| M | src/common/User/Account/Register/ProcessAdminRegisterFormController.php | +1 | −3 | Go to diff View file |
| M | src/common/User/Account/Register/ProcessRegisterFormController.php | +4 | −12 | Go to diff View file |
| A | src/common/User/Account/Register/RegisterFormContext.php | +44 | −0 | Go to diff View file |
| M | src/common/User/Account/Register/RegisterFormDisplayer.php | +4 | −6 | Go to diff View file |
| M | src/common/User/Account/Register/RegisterFormHandler.php | +4 | −1 | Go to diff View file |
| M | src/common/User/Account/Register/RegisterFormPresenterBuilder.php | +5 | −7 | Go to diff View file |
| M | src/common/User/Account/Register/RegisterFormProcessor.php | +6 | −6 | Go to diff View file |
| M | tests/unit/common/User/Account/Register/DisplayRegisterFormControllerTest.php | +15 | −31 | Go to diff View file |
| M | tests/unit/common/User/Account/Register/IDisplayRegisterFormStub.php | +3 | −3 | Go to diff View file |
| M | tests/unit/common/User/Account/Register/IProcessRegisterFormStub.php | +3 | −3 | Go to diff View file |
| M | tests/unit/common/User/Account/Register/ProcessRegisterFormControllerTest.php | +14 | −30 | Go to diff View file |