Public

Project privacy set to public. By default, its content is available to everyone (authenticated or not). Please note that more restrictive permissions might exist on some items.

stable

Clone or download

Read-only

Refactoring: split Manager into Factory+Creator

Download Browse

Part of story #8813 Manage Permission In order to respect Single Responsibility Principle, split the AccessFileHistoryManager into 2 objects: one to build AccessFileHistory instances and one to save new accessfile in db/filesystem. Change-Id: Id786ab5e53db9728778160e99172aa3f077aefc9

+193 −96
Nicolas Terray (nterray) 2016-02-24 11:09
Nicolas Terray (nterray) 2016-02-24 13:52
83dfb4714cf750b4d52258df20067fb7b081df56
099616788bd5ea9f98386cdfdbb9c761bbdda077
git #tuleap/stable/83dfb4714cf750b4d52258df20067fb7b081df56

Modified Files

Side by side diff
Inline diff
Name
M plugins/svn/include/Svn/AccessControl/AccessControlController.php +25 −67 Go to diff View file
A plugins/svn/include/Svn/AccessControl/AccessFileHistoryCreator.php +99 −0 Go to diff View file
R plugins/svn/include/Svn/AccessControl/AccessFileHistoryManager.php Go to diff View file
A plugins/svn/include/Svn/AccessControl/AccessFileHistoryNotFoundException.php +25 −0 Go to diff View file
M plugins/svn/include/autoload.php +5 −3 Go to diff View file
M plugins/svn/include/svnPlugin.class.php +39 −26 Go to diff View file