Public

Project privacy set to public. By default, its content is available to everyone (authenticated or not). Please note that more restrictive permissions might exist on some items.

stable

Clone or download

Read-only

Do not display xRef for unreadable FRS files

Download Browse

This is part of story #17180 take into account gitlab commits How to test: - Have a FRS release with at least one file - Have 2 users: -> User A can access to the FRS release (and can download the file) -> User B can't access to this release (and can't downaload the file when you fork url [0]) - Create a xRef with this FRS release in an artifact: for example in follow-ups "file #2" Expected results: - If the file exists, then only User A can access to the xRef - If the file doesn't exist (you created a xRef with a bad id), then nobody can see the xRef [0] For example, you can change the URL to: /file/download/$id where $id is a file that can't be reached by the user Change-Id: I07035bb07272ba4ff48ad771c9fdf4e9e541b57b

+122 −0
Benjamin Bouillot (ben.bouillot) 2020-12-28 17:01
Benjamin Bouillot (ben.bouillot) 2020-12-30 08:38
84f1fe7bd0bca06ece62fc6df31edd6a7d5478b6
c3f3918958cd7679685eab38265174170237c73d
git #tuleap/stable/84f1fe7bd0bca06ece62fc6df31edd6a7d5478b6

Modified Files

Side by side diff
Inline diff
Name
M plugins/tracker/include/Tracker/FormElement/Tracker_FormElement_Field_CrossReferences.php +1 −0 Go to diff View file
M src/common/Reference/ByNature/CrossReferenceByNatureInCoreOrganizer.php +3 −0 Go to diff View file
M src/common/Reference/ByNature/FRS/CrossReferenceFRSOrganizer.php +26 −0 Go to diff View file
M tests/unit/common/Reference/ByNature/CrossReferenceByNatureInCoreOrganizerTest.php +21 −0 Go to diff View file
M tests/unit/common/Reference/ByNature/FRS/CrossReferenceFRSOrganizerTest.php +71 −0 Go to diff View file