stable
Clone or download
Read-only
\array_search() can return 0 (which is evaluated as false) so to test for the existance (or absence) of a key you either need to explicitly check for \false or use the more appropriate \in_array(). In the present case the issue is deeper than that, the verification is done twice in two different ways. This contribution fixes the initial issue by removing the broken verification and improves the error message so it's easier to understand for the users what's the actual issue. Issue introduced by 646be67d7d9fc1a89f1ed3c8fc38f783599337cd. Part of story #22210: select SAFe templates at project creation Change-Id: I3bac40bdc85820f8542675a8930793c2ad9c6e5f
Modified Files
| Name | ||||
|---|---|---|---|---|
| M | plugins/program_management/include/program_managementPlugin.php | +0 | −8 | Go to diff View file |
| M | site-content/fr_FR/LC_MESSAGES/tuleap-core.po | +7 | −3 | Go to diff View file |
| M | src/common/Project/REST/v1/ProjectCreationDataPOSTProjectBuilder.php | +1 | −2 | Go to diff View file |
| M | src/common/Project/REST/v1/ProjectResource.class.php | +0 | −21 | Go to diff View file |
| M | src/common/Project/REST/v1/RestProjectCreator.php | +2 | −2 | Go to diff View file |
| D | src/common/Project/Registration/Template/Events/CollectAuthorizedXMLTemplateNamesEvent.php | +0 | −54 | Go to diff View file |
| M | src/common/Project/Registration/Template/Events/CollectCategorisedExternalTemplatesEvent.php | +1 | −1 | Go to diff View file |
| M | src/common/Project/Registration/Template/InvalidXMLTemplateNameException.php | +9 | −3 | Go to diff View file |
| A | src/common/Project/Registration/Template/NoTemplateProvidedException.php | +37 | −0 | Go to diff View file |
| M | src/common/Project/Registration/Template/TemplateFactory.php | +8 | −14 | Go to diff View file |
| M | tests/unit/common/Project/Registration/Template/TemplateFactoryTest.php | +1 | −3 | Go to diff View file |