Public

Project privacy set to public. By default, its content is available to everyone (authenticated or not). Please note that more restrictive permissions might exist on some items.

stable

Clone or download

Read-only

refactor: Homogeneize Artifact return type

Download Browse

`\Tracker_ArtifactFactory::createArtifact` returns Artifact|false `\Tuleap\Tracker\Artifact\Creation\TrackerArtifactCreator::create` returns Artifact|null In order to be able to remove \Tracker_ArtifactFactory::createArtifact`, we need first to make sure that it returns the same type: `?Artifact`. No functional changes. Part of request #36805: Kanban item not found when creating a card in Kanban Change-Id: I99208f5f65b696503ba15070323a862a93b0d642

+8 −20
Nicolas Terray (nterray) 2024-02-09 11:35
Nicolas Terray (nterray) 2024-02-09 11:35
892473656b82a5a76dd61093dea199732cce3546
82dfd3a6cbf01191cf5dadcd0c76bf9839673207
git #tuleap/stable/892473656b82a5a76dd61093dea199732cce3546

Modified Files

Side by side diff
Inline diff
Name
M plugins/tracker/include/REST/Artifact/ArtifactCreator.php +1 −1 Go to diff View file
M plugins/tracker/include/Tracker/Action/CreateArtifact.class.php +1 −3 Go to diff View file
M plugins/tracker/include/Tracker/Action/CreateArtifactFromModal.class.php +1 −1 Go to diff View file
M plugins/tracker/include/Tracker/Artifact/MailGateway/MailGateway.class.php +2 −3 Go to diff View file
M plugins/tracker/include/Tracker/Artifact/Tracker_ArtifactFactory.class.php +3 −12 Go to diff View file